Skip to content

Conversation

@EvgeniyPatlan
Copy link
Collaborator

No description provided.

@EvgeniyPatlan EvgeniyPatlan requested a review from a team as a code owner September 23, 2025 18:02
@nogueiraanderson
Copy link
Contributor

nogueiraanderson commented Sep 24, 2025

Line 21 uses uniq -u which outputs entries appearing in only one file:

cat ${REPO_NAME}.last ${REPO_NAME}.current | sort | uniq -u

This reports both new tags AND deleted tags, causing 404 URLs in Slack notifications.

Test Case

# last: v1.0.0, v1.0.1, v1.0.2
# current: v1.0.0, v1.0.2, v2.0.0

$ cat last current | sort | uniq -u
v1.0.1  # deleted tag - generates 404 URL
v2.0.0  # new tag

$ comm -13 <(sort last) <(sort current)
v2.0.0  # correctly shows only new tag

Suggested fix

comm -13 <(sort ${REPO_NAME}.last) <(sort ${REPO_NAME}.current) | \
  awk '{print "'${REPO_URL}'/tree/"$1}' > ${REPO_NAME}.newtags

@EvgeniyPatlan EvgeniyPatlan merged commit 6143af1 into master Oct 10, 2025
@EvgeniyPatlan EvgeniyPatlan deleted the PKG-1082 branch October 10, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants