-
Notifications
You must be signed in to change notification settings - Fork 589
Add DNS Module #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add DNS Module #761
Conversation
Add dns Modüle Signed-off-by: Hakan Yavuz <[email protected]>
Add DNS module Signed-off-by: Hakan Yavuz <[email protected]>
| self.module_options = module_options | ||
| self.show_usage = False | ||
|
|
||
| if "HELP" in module_options or "H" in module_options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for the help option when it defaults to showing the usage if the action is not a valid option anyway? Just seems redundant with the existing --options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --options menu should provide the basic explanation and maybe 2-3 examples. If that is not enough the wiki should be the place for detailed information and explanations imo.
|
Thanks for the PR! Could you PR all of the structs to impacket? That is probably the better place instead of that NetExec builds its own lib. Also other people can use them if needed. |
|
fortra/impacket#1994 |

Description
This pull request introduces a new module, dns, for managing DNS records within an Active Directory-integrated DNS environment directly via LDAP. It provides administrators and pentesters with a powerful command-line tool to perform various DNS operations, from creating and deleting records to querying existing zones, without leaving the NetExec console.
This module is inspired by the functionality of dnstool.py from krbrelayx by @dirkjanm and is designed to be a robust and user-friendly addition to NetExec's capabilities.
Key Features
Help Usage

Query Usage

Forest Query Usage

Add Usage

Forest Add Usage

Add AllowMultiple Usage

Modify Usage

Remove Usage

Ldap Remove Usage

List

List-DN

Type of change
Setup guide for the review
Please provide guidance on what setup is needed to test the introduced changes, such as your locally running machine Python version & OS, as well as the target(s) you tested against, including software versions.
In particular:
Screenshots (if appropriate):
Screenshots are always nice to have and can give a visual representation of the change.
If appropriate include before and after screenshot(s) to show which results are to be expected.
Checklist:
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)