-
Notifications
You must be signed in to change notification settings - Fork 715
Allow for users to set an arbitrary level when calling qml.specs
#8606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jzaia18
wants to merge
281
commits into
master
Choose a base branch
from
feature/specs-levels
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+583
−68
Open
Changes from 250 commits
Commits
Show all changes
281 commits
Select commit
Hold shift + click to select a range
4b5153e
Clean up specs code
jzaia18 0c0683f
oops all type hints
jzaia18 963d60f
Cleaner error messages
jzaia18 9f2664a
Fix specs not properly handling tape transforms with capture enabled
jzaia18 76639cf
Linting
jzaia18 d9fa927
Support ranges
jzaia18 79bb963
Merge branch 'main' into chore/xdsl-utils
jzaia18 9bb09f3
Merge branch 'chore/xdsl-utils' into feature/specs-levels
jzaia18 649f328
Rename visualization to inspection
jzaia18 b3c332a
Merge branch 'chore/xdsl-utils' into feature/specs-levels
jzaia18 59ad388
Fix missed spots
jzaia18 6ad2907
Temp
jzaia18 023da7e
Merge branch 'chore/xdsl-utils' into feature/specs-levels
jzaia18 a05ec98
Make format
jzaia18 45b8782
Merge branch 'chore/xdsl-utils' into feature/specs-levels
jzaia18 d7f72dc
UI cleanup
jzaia18 69cd5a6
More cleanup
jzaia18 7fc2f0d
Move get_mlir_module to shared utility file
jzaia18 13e6b4a
Merge branch 'chore/xdsl-utils' into feature/specs-levels
jzaia18 1eb76f7
Remove redundant code
jzaia18 1308ca3
Build out framework for unit testing mlir_specs
jzaia18 7ebd5e5
Merge branch 'main' into chore/xdsl-utils
jzaia18 49bd139
Merge branch 'chore/xdsl-utils' into feature/specs-levels
jzaia18 6e9fac3
Specs testing
jzaia18 cf187da
Add more mlir_specs tests. Run all tests with AND without PLxPR
jzaia18 daebf3e
Test more level values
jzaia18 715bda4
Merge branch 'main' into chore/xdsl-utils
jzaia18 d3466d5
Merge branch 'chore/xdsl-utils' into feature/specs-levels
jzaia18 d828d90
Remove specs integration from this branch
jzaia18 2ffd877
Merge mlir_specs into branch
jzaia18 4fd3991
Better handle user specified compilation options
jzaia18 b849bba
Merge branch 'chore/xdsl-utils' into feature/mlir-specs
jzaia18 5df2973
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 e90d3b5
Skip external function declarations
jzaia18 51e3ca5
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 3b34f09
remove unused qjit from xdsl_conversion.py
andrijapau 9ea75bc
Merge branch 'main' into chore/xdsl-utils
jzaia18 940ba41
Merge branch 'chore/xdsl-utils' into feature/mlir-specs
jzaia18 5f9674a
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 5a243ca
Begin adding support for CallOp
jzaia18 87f4d5a
Fix xDSL conversion to once again allow for QNodes
jzaia18 c0d04da
rename remove-chained-self-inverses to cancel-inverses
andrijapau 05947fd
Merge branch 'main' into chore/xdsl-utils
jzaia18 7314cfd
Merge branch 'chore/xdsl-utils' into feature/mlir-specs
jzaia18 3a3f2c4
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 200e687
Support function calls
jzaia18 dabf998
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 4c3e2b0
Temp fixes to get around bug in FTQC specs collection
jzaia18 f0e56e7
Oops, typo
jzaia18 862bf44
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 8156919
Take max instead of sum for conditionals
jzaia18 739bd51
Revert change to resource tracking specs
jzaia18 d3b415f
Add 'mlir-specs' option
jzaia18 93e1f22
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 1d234d2
Support IndexSwitchOp
jzaia18 729f882
Merge branch 'main' into feature/mlir-specs
jzaia18 752303f
Ensure dialects are fully recognized
jzaia18 f9edccd
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 415f9d1
More dialect support
jzaia18 17628e9
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 191b07a
Small name change to accomodate new mlir_specs changes
jzaia18 43ec629
Fix several unit tests
jzaia18 f182b89
More cleanup
jzaia18 6e86005
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 0ebd9ef
Specs output
jzaia18 38fff07
change how resource size is tracked
jzaia18 c150bc3
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 f39afc0
Cleanup
jzaia18 9849387
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 6460a16
Integrate with changes to how mlir_specs stores data
jzaia18 53def9b
Handle adjoint op
jzaia18 6f2486d
More cleanup
jzaia18 9fcbc9d
More unit tests
jzaia18 97e2126
Merge branch 'main' into feature/specs-levels
jzaia18 711920b
Merge branch 'main' into feature/mlir-specs
jzaia18 5b4fe8d
Merge branch 'feature/mlir-specs' into feature/specs-levels
jzaia18 f92ca68
Revert changes inherited from other branches (unified compiler migrat…
jzaia18 d5ae1f7
Compiler moved
jzaia18 8b675bd
Disentangle this branch from new specs features
jzaia18 5c37ef3
Update unit tests to match new specs
jzaia18 651ae93
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 7c42d74
Fix botched merge
jzaia18 d37e027
Formatting
jzaia18 1ad4919
Make more tests pass
jzaia18 0799379
Update docs
jzaia18 f89312e
More tweaks to how resources are returned
jzaia18 8b0d16e
Fix more unit tests
jzaia18 3cb11ac
Yet more test tweaks
jzaia18 335caa4
More updates
jzaia18 039512a
Merge branch 'master' into chore/specs-outputs
jzaia18 cef960f
Fix last failing test
jzaia18 336e9c7
Merge branch 'chore/specs-outputs' of github.com:PennyLaneAI/pennylan…
jzaia18 4eb692d
Docs for SpecsResources
jzaia18 a63dcb1
Fix yet another test
jzaia18 592ffc0
Add docs for SpecsResult
jzaia18 243692d
These tests Q-Q
jzaia18 3f0c23a
Merge branch 'master' into chore/specs-outputs
jzaia18 3dfc168
Unit tests for SpecsResources
jzaia18 88eaec0
Merge branch 'chore/specs-outputs' of github.com:PennyLaneAI/pennylan…
jzaia18 7f833cd
Re-add tests for _count_resources
jzaia18 d2e5569
Re-add tests for _count_resources
jzaia18 53aa47d
Merge branch 'master' into chore/specs-outputs
jzaia18 ba0514c
Test to_dict
jzaia18 321d605
Tests for SpecsResult
jzaia18 ef97962
Merge branch 'chore/specs-outputs' of github.com:PennyLaneAI/pennylan…
jzaia18 cd117ba
Docs updates
jzaia18 e448e77
Update changelog
jzaia18 8f09c21
Update pennylane/devices/_qubit_device.py
jzaia18 35f6698
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 04285d0
Rename SpecsResult to CircuitSpecs
jzaia18 d8266ac
Missed one!
jzaia18 b4238ed
Update how multi-controlled gates are displayed in specs
jzaia18 3fd0bca
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 8de9d4c
Missed one!
jzaia18 be91036
Rename 1st transform level
jzaia18 b7ab2e9
Docs updates
jzaia18 93535e7
More docs updates
jzaia18 9322d20
Update formatting of null.qubit in docs
jzaia18 397a15e
Sphinx?
jzaia18 17691de
Indenting got messed up
jzaia18 4fc0da1
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 817500b
More docs fixes
jzaia18 d78e309
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 fd1e2fb
Merge branch 'main' into chore/specs-outputs
jzaia18 6bdefa1
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 682546e
Use new pass names
jzaia18 ca1a13f
Smarter compute_depth to avoid extraneous warnings
jzaia18 a5d76da
Oops
jzaia18 3081978
Better separation for pretty printing
jzaia18 239f9b7
Better output for 'level'
jzaia18 a435f85
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 60e90af
ipython display
jzaia18 a034f6d
Magical BLANKLINE incantations
jzaia18 c20c38a
Streamline resource conversion
jzaia18 ca47e4b
Merge branch 'master' into chore/specs-outputs
jzaia18 45a3ad9
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 0230d47
Apply suggestions from code review
jzaia18 c07f560
Format
jzaia18 970df34
Remove unused import
jzaia18 7453239
Make qml.specs work with the new marker transforms
jzaia18 b40c925
Remove 'pycon' codeblock
jzaia18 57a00b1
Add new unit test for qml.marker with qml.specs
jzaia18 b2bf47b
Merge branch 'master' into chore/specs-outputs
jzaia18 1d58ba4
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 a0012a5
Update how str is made
jzaia18 1fe81dd
Update docs
jzaia18 d18c41d
Merge branch 'master' into chore/specs-outputs
jzaia18 436aa81
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 55c3951
Bad return type
jzaia18 7410293
Small update
jzaia18 f81bae9
Return observable info within measurements for plain PL specs
jzaia18 5ce0ab4
Merge branch 'main' into chore/specs-outputs
jzaia18 53edb6d
Update unit tests
jzaia18 e63fdf4
Update docs
jzaia18 e65c72b
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 e1e3af3
Skip coverage on ipython display helper
jzaia18 65f7359
Changes for better marker behaviour
jzaia18 b3b2b24
Add hamiltonian tests
jzaia18 f78be3f
Merge branch 'master' into chore/specs-outputs
jzaia18 bca94d4
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 b7d54f4
Change how batching is handled
jzaia18 aba6550
Docs fixes
jzaia18 78f64ac
Apply suggestions from code review
jzaia18 7c4994a
Docs changes
jzaia18 1b31c14
Merge branch 'chore/specs-outputs' of github.com:PennyLaneAI/pennylan…
jzaia18 8f4e995
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 54c298a
Minor typo
jzaia18 bc1ff64
Switch back to list as possible output
jzaia18 34f2398
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 dcfee7b
Fix printing for CircuitSpecs
jzaia18 77e9543
Fix doctests
jzaia18 ab070dd
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 51ca4b1
Clean up specs output
jzaia18 9531387
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 ea8582f
Minor tweak
jzaia18 eebde8d
Placate codefactor
jzaia18 29ebfbb
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 294f2fb
More thorough testing for new batch output
jzaia18 5250274
Add more coverage
jzaia18 192849a
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 f3b7ec3
Apply suggestions from code review
jzaia18 74cfce3
Merge branch 'master' into chore/specs-outputs
jzaia18 b894da4
Implement Anton's suggestions
jzaia18 1031a2c
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 1e8a45a
Apply suggestions from code review
jzaia18 e80bd40
Merge branch 'master' into chore/specs-outputs
jzaia18 cf9c3b3
Update how hamiltonians are tracked
jzaia18 8efa45b
Merge branch 'master' into chore/specs-outputs
jzaia18 4268a68
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 a694229
Update test
jzaia18 39e4601
Merge branch 'master' into chore/specs-outputs
jzaia18 ac15ca0
Merge branch 'master' into chore/specs-outputs
jzaia18 4b3ee0c
Standardize how observables are printed
jzaia18 03045c3
Merge branch 'chore/specs-outputs' of github.com:PennyLaneAI/pennylan…
jzaia18 c03c44b
Doctests
jzaia18 1103800
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 842bbe8
Improve error messages for bad pass levels
jzaia18 fed1a3d
Update pennylane/resource/__init__.py
jzaia18 ff91811
Fix missing import
jzaia18 bb3fdab
Docs updates
jzaia18 6f797fc
Coverage
jzaia18 337ddf0
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 b9fcbf1
Merge branch 'master' into chore/specs-outputs
jzaia18 1a6e40d
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 ccbf8c6
Merge branch 'master' into chore/specs-outputs
jzaia18 7e3809b
Codecov
jzaia18 0a37c89
Merge branch 'chore/specs-outputs' into feature/specs-levels
jzaia18 9cd3a32
Merge branch 'main' into feature/specs-levels
jzaia18 cff98ee
Merge branch 'master' into feature/specs-levels
jzaia18 f5005e3
Changelog entry
jzaia18 f7b0b9e
Merge branch 'feature/specs-levels' of github.com:PennyLaneAI/pennyla…
jzaia18 f442348
Streamline level parsing
jzaia18 0d783c5
Ensure sybil has xdsl installed for necessary doctests
jzaia18 3ebaf68
Ensure sybil has xdsl installed for necessary doctests
jzaia18 fd5609b
Fix doctest
jzaia18 0a1eea2
Fix wrong PR number
jzaia18 111414a
Coverage
jzaia18 dd836fb
Merge branch 'master' into feature/specs-levels
jzaia18 93aed34
Maybe fix sphinx issues?
jzaia18 dd1a625
Coverage
jzaia18 8493183
Improve specs docstring
jzaia18 578ddff
Improve CircuitSpecs docstring
jzaia18 5a928be
Merge branch 'master' into feature/specs-levels
jzaia18 c7f1815
Apply suggestions from code review
jzaia18 2f473e3
Apply suggestions from code review
jzaia18 12334e1
Merge branch 'master' into feature/specs-levels
jzaia18 d7462ed
Apply some of Isaac's feedback
jzaia18 499a287
Rename 'qubits' -> 'wires'
jzaia18 4fea2b5
Show how to index into CircuitSpecs
jzaia18 5e8b12b
Merge branch 'master' into feature/specs-levels
jzaia18 d930dc2
Apply suggestions from code review
jzaia18 ddc627d
Merge branch 'master' into feature/specs-levels
jzaia18 e7a99b7
Format
jzaia18 623c74c
Apply suggestions from code review
jzaia18 1481a90
Docs update for compute depth
jzaia18 c5e966e
Merge branch 'feature/specs-levels' of github.com:PennyLaneAI/pennyla…
jzaia18 a9f8add
Update order of examples in specs docstring
jzaia18 114717a
Apply suggestion from @isaacdevlugt
jzaia18 45d9bf7
More docs tweaks
jzaia18 f32d55e
Formatting
jzaia18 035ac6d
Fix bug in transform level enumeration
jzaia18 d94b1b6
Merge branch 'master' into feature/specs-levels
jzaia18 9fb8f1e
Apply suggestions from code review
jzaia18 d6d07a6
Merge branch 'master' into feature/specs-levels
jzaia18 6616f34
Add better typing to specs args
jzaia18 fe2314e
Merge branch 'master' into feature/specs-levels
jzaia18 315f0f1
Small docs tweak
jzaia18 412f48e
Merge branch 'master' into feature/specs-levels
jzaia18 076d636
Merge branch 'master' into feature/specs-levels
isaacdevlugt db3fae0
moved warning
isaacdevlugt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on discussion in yesterday's meeting, we may want to pin the xdsl/-jax versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the plan is to add these as Catalyst dependencies, this change wouldn't be needed at all (since we'd get these packages when we install Catalyst 2 steps prior)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan is to add them as dependencies 😁