Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
PietropaoloFrisoni
approved these changes
Feb 25, 2025
Contributor
PietropaoloFrisoni
left a comment
PietropaoloFrisoni
left a comment
There was a problem hiding this comment.
Thank you @rashidnhm ! 🚀
JerryChen97
approved these changes
Feb 25, 2025
Contributor
JerryChen97
left a comment
JerryChen97
left a comment
There was a problem hiding this comment.
Thanks a lot for saving the CI! Fingers Crossed
albi3ro
approved these changes
Feb 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7005 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 483 483
Lines 46066 46066
=======================================
Hits 45881 45881
Misses 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerryChen97
added a commit
that referenced
this pull request
Feb 25, 2025
**Context:** Same as #7005, but for gpu test yml file **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
setuptools has had a release recently that normalizes package names:
References:
Description of the Change:
Due setuptools 75.8.0 and 75.8.1 outputting completely different package names, we cannot support both, so CI now "pins" to >=75.8.1.
Benefits:
Fix CI failures.
Possible Drawbacks:
We may need to update docs.
This is also another situation where moving away from setup.py to pyproject would yield benefits. As then you can specify the minimum setuptools version as part of the build-backend configuration.
Related GitHub Issues:
None. sc-85195