Skip to content

Conversation

@JerryChen97
Copy link
Contributor

@JerryChen97 JerryChen97 commented Apr 16, 2025

unpin scipy

Changes: follow #78 to simplify the requirements.txt so that we are free of CodeFactor complaints.

Benefits:

  1. Fixing https://app.readthedocs.com/projects/xanaduai-pennylane-aqt/builds/2972169/ which was caused by a super old scipy whose version pinned three years ago.
  2. Advanced the needed requirements change there as well.

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4e0236f) to head (b0c9ec8).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          171       171           
=========================================
  Hits           171       171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JerryChen97 JerryChen97 requested a review from andrijapau April 16, 2025 17:38
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codefactor?

@JerryChen97
Copy link
Contributor Author

I don't think the CodeFactor complaint on requriements line0 makes any sense...

@andrijapau
Copy link
Contributor

During hackweek i was cleaning up this repo and found that the requirements can be simplified greatly. Try that.
image

#78

@astralcai
Copy link
Contributor

In this case I wonder if requirements.txt is even needed

@JerryChen97 JerryChen97 merged commit bdc0a4b into master Apr 16, 2025
8 checks passed
@JerryChen97 JerryChen97 deleted the upgrade-scipy branch April 16, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants