Remove references to the xdsl pass plugin in existing tests and docs #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello. You may have forgotten to update the changelog!
|
mudit2812
approved these changes
Dec 8, 2025
frontend/catalyst/python_interface/doc/unified_compiler_cookbook.rst
Outdated
Show resolved
Hide resolved
Contributor
|
As a follow up, we should update the callback functions (draw, mlir-graph, specs, graph viz) to stop using the plugin as well. This would require us to update how we're implementing the functionality entirely, so no need to do it right now. |
…ok.rst Co-authored-by: Mudit Pandey <[email protected]>
paul0403
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
As #2169 have added auto detection of xdsl passes, we don't need to specify the pass plugin argument in the tests
Description of the Change:
Remove the reference to xdsl pass plugin within the test suit.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-101160]