Skip to content

Conversation

@kipawaa
Copy link
Contributor

@kipawaa kipawaa commented Dec 2, 2025

Context:
We've added arbitrary angle PPRs, but merge_rotations ignores them.

Description of the Change:
Adds support for arbitrary angle qec.ppr.arbitrary pprs to the merge_rotations pass.
The added rule merges PPRs as follows:

PPR(theta) * PPR(theta') -> PPR(theta + theta')

The rule supports conditions, re-ordering of Pauli words and qubits, and arbitrary sized PPRs.

Benefits:
merge_rotations simplifies QEC workflows as expected.

@kipawaa kipawaa changed the title initial implementation and tests merge_rotations arbitrary angle ppr support Dec 2, 2025
@kipawaa kipawaa marked this pull request as ready for review December 3, 2025 19:18
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.06%. Comparing base (10b38c6) to head (3f869d3).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2258       +/-   ##
===========================================
- Coverage   97.57%   73.06%   -24.52%     
===========================================
  Files          93      143       +50     
  Lines       11245    14971     +3726     
  Branches     1076     1576      +500     
===========================================
- Hits        10972    10938       -34     
- Misses        208     3966     +3758     
- Partials       65       67        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@rniczh rniczh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kipawaa 💯 Just a fly-by comment

@kipawaa kipawaa marked this pull request as draft December 3, 2025 21:30
@kipawaa kipawaa marked this pull request as ready for review December 4, 2025 20:45
Copy link
Member

@paul0403 paul0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some final small things : )

@paul0403 paul0403 requested a review from sengthai December 5, 2025 19:55
@kipawaa
Copy link
Contributor Author

kipawaa commented Dec 9, 2025

@sengthai friendly reminder for review when you have the time :)

Copy link
Member

@paul0403 paul0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @sengthai @lazypanda10117 either of you has time to give a second approval?

@lazypanda10117
Copy link
Member

Nice! @sengthai @lazypanda10117 either of you has time to give a second approval?

I had a quick look and it looks good. It shouldn't conflict with my PR changes. Will do a proper review later today.

@lazypanda10117 lazypanda10117 self-requested a review December 12, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants