-
Notifications
You must be signed in to change notification settings - Fork 59
merge_rotations arbitrary angle ppr support #2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
===========================================
- Coverage 97.57% 73.06% -24.52%
===========================================
Files 93 143 +50
Lines 11245 14971 +3726
Branches 1076 1576 +500
===========================================
- Hits 10972 10938 -34
- Misses 208 3966 +3758
- Partials 65 67 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rniczh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kipawaa 💯 Just a fly-by comment
Co-authored-by: Paul <[email protected]>
paul0403
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just some final small things : )
|
@sengthai friendly reminder for review when you have the time :) |
paul0403
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! @sengthai @lazypanda10117 either of you has time to give a second approval?
I had a quick look and it looks good. It shouldn't conflict with my PR changes. Will do a proper review later today. |
Context:
We've added arbitrary angle PPRs, but
merge_rotationsignores them.Description of the Change:
Adds support for arbitrary angle
qec.ppr.arbitrarypprs to themerge_rotationspass.The added rule merges PPRs as follows:
The rule supports conditions, re-ordering of Pauli words and qubits, and arbitrary sized PPRs.
Benefits:
merge_rotationssimplifies QEC workflows as expected.