-
Notifications
You must be signed in to change notification settings - Fork 59
Implement new mlir_specs Python function to get resource counts from MLIR passes
#2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neAI/catalyst into migrate-unified-compiler
…_in_dim verify methods
…neAI/catalyst into migrate-unified-compiler
…neAI/catalyst into migrate-unified-compiler
Co-authored-by: David Ittah <[email protected]>
mudit2812
approved these changes
Dec 5, 2025
Contributor
mudit2812
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
andrijapau
approved these changes
Dec 5, 2025
Contributor
andrijapau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - nice work!
Contributor
Author
|
Awesome! Thanks for the reviews. Will wait to merge this until after the migration PR gets merged to main. |
lazypanda10117
pushed a commit
that referenced
this pull request
Dec 8, 2025
…m MLIR passes (#2238) **Context:** There is currently no way to view the impact to runtime costs of a given MLIR pass from the python frontend of PennyLane. **Description of the Change:** Creates a new `mlir_specs` function, in addition to a `specs_collect` function which uses xDSL to allow inspection of compilation passes written in MLIR. **Benefits:** Allows users to evaluate the impact on the IR of various MLIR passes. **Possible Drawbacks:** Not integrated with `qml.specs()`, this will be handled in a followup PR. **Related GitHub Issues:** [sc-103510] Migrated from PennyLaneAI/pennylane#8660 See also the frontend integration for this PR: PennyLaneAI/pennylane#8606 --------- Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: Mehrdad Malek <[email protected]> Co-authored-by: David Ittah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
There is currently no way to view the impact to runtime costs of a given MLIR pass from the python frontend of PennyLane.
Description of the Change:
Creates a new
mlir_specsfunction, in addition to aspecs_collectfunction which uses xDSL to allow inspection of compilation passes written in MLIR.Benefits:
Allows users to evaluate the impact on the IR of various MLIR passes.
Possible Drawbacks:
Not integrated with
qml.specs(), this will be handled in a followup PR.Related GitHub Issues:
[sc-103510]
Migrated from PennyLaneAI/pennylane#8660
See also the frontend integration for this PR: PennyLaneAI/pennylane#8606