-
Notifications
You must be signed in to change notification settings - Fork 59
feat: visualize static operators and measurements as nodes #2218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: visualize static operators and measurements as nodes #2218
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/graph-visualization #2218 +/- ##
==============================================================
Coverage ? 97.66%
==============================================================
Files ? 93
Lines ? 10899
Branches ? 1039
==============================================================
Hits ? 10645
Misses ? 195
Partials ? 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frontend/catalyst/python_interface/visualization/construct_circuit_dag.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mehrdad Malek <[email protected]>
…lder.py Co-authored-by: Mehrdad Malek <[email protected]>
…lder.py Co-authored-by: Mehrdad Malek <[email protected]>
…_dag_builder.py Co-authored-by: Mehrdad Malek <[email protected]>
…lder.py Co-authored-by: Mehrdad Malek <[email protected]>
Co-authored-by: Mehrdad Malek <[email protected]>
This reverts commit 57ce573.
frontend/catalyst/python_interface/visualization/construct_circuit_dag.py
Outdated
Show resolved
Hide resolved
frontend/catalyst/python_interface/visualization/construct_circuit_dag.py
Outdated
Show resolved
Hide resolved
| self._node_uid_counter += 1 | ||
|
|
||
| @_visit_operation.register | ||
| def _visit_sample_and_probs_ops( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about counts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I don't really see why you're handling all the measurements in separate functions. Let me know if your agree, but they seem too similar to need different dispatches. I think a match-case might make more sense. I can totally be convinced otherwise though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about counts?
Turns out Pietro's work didn't have support for counts 😬. Not sure why.
…cuit_dag.py Co-authored-by: Mudit Pandey <[email protected]>
This PR adds basic visualization support for operators and measurement nodes in the DAG.
[sc-104322]