Skip to content
This repository was archived by the owner on Apr 19, 2023. It is now read-only.

Conversation

dhasegan
Copy link
Contributor

Discussion is here: #473

I am still debugging this so don't pull this in yet.

@dhasegan
Copy link
Contributor Author

do I have to change tmask to ones in utils/tfilter ?

tmask=ones

to:

tmask=zeros

@dhasegan dhasegan marked this pull request as ready for review January 12, 2022 18:38
@dhasegan
Copy link
Contributor Author

I tested the last version and it correctly processed my volumes (both censored and not).
I think it's safe to push this and I can chat about it if needed.

@dhasegan
Copy link
Contributor Author

For example, my qcfc figure resulting from 125 volumes censored (using a variation of the fc-36p_scrub.dsn):
Screen Shot 2022-01-12 at 10 42 18 AM

Copy link
Contributor

@a3sha2 a3sha2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhasegan thank you very much,
tmask is set to 1 for any flag volumes if we change this now, this has to be changed during interpolation

@a3sha2
Copy link
Contributor

a3sha2 commented Jan 14, 2022

that figure is correct for scrubbing outputs. It is necessary to indicate which volumes were flagged, that is why you see c two residual images in regress folder, one without scrubbed volumes and the other with scrubbed volumes

@dhasegan
Copy link
Contributor Author

I see them, its the _residualized_dtseries.svg and _residualized_hemi-L_bold.func.svg for left hemisphere.

Looks good to me. Is there anything else that I should do for this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants