mysql: context #2619
Merged
mysql: context #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
commented
Feb 21, 2025
flow/connectors/mysql/mysql.go
Outdated
| logger log.Logger | ||
| config *protos.MySqlConfig | ||
| ssh utils.SSHTunnel | ||
| conn atomic.Pointer[client.Conn] |
There was a problem hiding this comment.
note that the use of atomics here does not expose a threadsafe interface, this is only to avoid race conditions on c.conn being replaced during retries & context watcher reading c.conn
There was a problem hiding this comment.
can be a comment just in case
serprex
force-pushed
the
mysql-context
branch
from
08f1b9c to
dce4fc9
Compare
heavycrystal
approved these changes
Feb 25, 2025
flow/connectors/mysql/mysql.go
Outdated
| logger log.Logger | ||
| config *protos.MySqlConfig | ||
| ssh utils.SSHTunnel | ||
| conn atomic.Pointer[client.Conn] |
There was a problem hiding this comment.
can be a comment just in case
serprex
force-pushed
the
mysql-context
branch
from
dce4fc9 to
8236d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on go-mysql-org/go-mysql#997 without having to switch to
database/sql