fix: ECDH with null length #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microshine
approved these changes
Nov 2, 2022
Collaborator
microshine
left a comment
microshine
left a comment
There was a problem hiding this comment.
Thank you for your update. All changes look well
Contributor
Author
|
@microshine thank you, wasn't the publish workflow from master supposed to succeed? |
Collaborator
|
|
Contributor
Author
|
Thank you,. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the ECDH deriveBits op when
nullis passed as length. This behaviour is covered by Web Platform Tests.The global DOM types will get updated as soon as the spec bug around actually passing
nullas length gets fixed.