Skip to content

don't use container #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

don't use container #3

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
42a7d94
don't use container
robkooper Aug 18, 2020
4e14bd6
use sudo
robkooper Aug 18, 2020
7a03da3
use sudo
robkooper Aug 18, 2020
aeacd7f
use sudo
robkooper Aug 18, 2020
9b73dbd
more fixes
robkooper Aug 18, 2020
42f09fc
fix docker
robkooper Aug 18, 2020
caa8c1d
fix docker
robkooper Aug 18, 2020
17a9d54
fix docker
robkooper Aug 18, 2020
315f712
install xml2
robkooper Aug 18, 2020
f420207
Merge branch 'master' into fix-github-actions
robkooper Oct 24, 2020
6023efd
Update ci.yml
robkooper Oct 24, 2020
f5fbf99
Update .github/workflows/ci.yml
robkooper Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ on:
push:
branches:
- master
- "*"
pull_request:


Expand All @@ -21,7 +20,6 @@ jobs:
- {os: ubuntu-16.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
- {os: ubuntu-18.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/bionic/latest"}

container: pecan/depends:develop
services:
postgres:
image: mdillon/postgis:9.5
Expand Down Expand Up @@ -49,14 +47,18 @@ jobs:
- uses: actions/checkout@v2

#- name: install utils
# run: apt-get update && apt-get install -y openssh-client postgresql-client curl
# run: |
# sudo apt-get update
# sudo apt-get install -y openssh-client postgresql-client curl

- name: db setup
uses: docker://pecan/db:latest

- name: create account
uses: docker://pecan/bety:latest
args: user carya illinois "Carya Demo User" [email protected] 1 1
uses: docker://pecan/bety:develop
with:
# entrypoint: /home/bety/script/betyuser.sh
args: user carya illinois "Carya Demo User" [email protected] 1 1
Comment on lines +60 to +61
Copy link
Member

@ashiklom ashiklom Nov 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I'm currently testing this out on a personal branch of this -- https://github.com/ashiklom/rpecanapi/runs/1386059263?check_suite_focus=true

UPDATE: This made it past this line, but failed on the actual R CMD check step.

Suggested change
# entrypoint: /home/bety/script/betyuser.sh
args: user carya illinois "Carya Demo User" [email protected] 1 1
entrypoint: /bin/bash
args: /home/bety/script/betyuser.sh carya illinois "Carya Demo User" [email protected] 1 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, I guess setting entrypoint: /home/bety/script/betyuser.sh might be a more straightforward version of the same thing.


- uses: r-lib/actions/setup-r@master
with:
Expand Down