-
Notifications
You must be signed in to change notification settings - Fork 270
Add write.events.SIPNET function #3623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Merging dlebauer#8 should resolve the current test failures |
@dlebauer seems like the proximal issue is the entries in events_site1.json being list instead of scalar, but I don't understand the intention behind that format enough to recommend a fix. |
@dlebauer reminder that this PR is still waiting for your input -- ping me if you want help on the test failures, but I'll need context from you to suggest the right fix. |
… from sipnet to data.land package
@infotroph if you want to take another look at the changes that I've made (f800475...dlebauer:write_events_sipnet) while trying to get the tests to pass, they include
|
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
…(3.1.0 was released in 2021) - add test that validate_events_json return NA if jsonvalidate not installed
Add function that converts a generic
events.json
(see #3621 and #3551) into sipnet-specificevents.in
files.Description
Includes:
write.events.SIPNET
Motivation and Context
Required to use PEcAn to configure SIPNET to simulate agronomic managements.
Review Time Estimate
Types of changes
Checklist: