-
Notifications
You must be signed in to change notification settings - Fork 0
feat: adding workflow to verify that changelog.d entries have been added. #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
LGTM. |
Are you suggesting it to avoid direct changes in the CHANGELOG.md file? or why are you suggesting it? @MAAngamarca |
|
yes, to avoid direct changes in that file. @Squirrel18 |
dd7cfaf to
97330b1
Compare
Description:
This PR is part of the new release process: #10 and adds a new workflow to verify that changelog.d entries have been added as part of the changes in a PR. All changes in a PR should include an entry describing the nature of the change using Scriv, this enforces Scriv to be used, maintaining an up-to-date changelog and applying good practices when opening PRs.
Test:
Notes:
github.head_refto the checkout Action so it can use the branch of the PR instead of the SHA ref.grep -q "^changelog\.d/.*\.md$". To make this more robust, we would require to interact with Scriv file naming pattern increasing the complexity of this Action. For now this is the least we can do to perform the check.Reviewers: