Skip to content

Conversation

@alexjmpb
Copy link
Contributor

@alexjmpb alexjmpb commented Jul 6, 2023

Description

This PR aims to solve a post migration issue reported (#78) in the issues spreadsheet. The issue consist in that the /courses page is showing all courses including those that are not desired to be shown, hence it's required to hide the Discover New tab to avoid users to access this page.

Type of change

  • Make the visibility of the Discover New tab toggleable with the SHOW_EXPLORE_COURSES site conf.

How to test

  • Checkout to this branch
  • Enable comprehensive theming
  • Compile themes
  • Add the pearson-theme to a site
  • Set the site configuration SHOW_EXPLORE_COURSES to true
  • Notice that now the Discover New tab is not shown in the header

Screenshots

image

Reviewers

@alexjmpb alexjmpb requested review from ShonTitor and Squirrel18 July 6, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant