Skip to content

Commit

Permalink
-Fixed readme
Browse files Browse the repository at this point in the history
-Removed extra new lines
-Placed date_filter warning on glassdoor.py and monster.py
  • Loading branch information
thebigG committed Mar 2, 2020
1 parent a82ecc8 commit 8cbe28f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions jobfunnel/glassdoor.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,8 @@ def scrape(self):
# key by id
self.scrape_data[str(job['id'])] = job

# Do not change the order of the next three statements if you want date_filter to work

# stores references to jobs in list to be used in blurb retrieval
scrape_list = [i for i in self.scrape_data.values()]
# converts job date formats into a standard date format
Expand Down
2 changes: 2 additions & 0 deletions jobfunnel/monster.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ def scrape(self):
# key by id
self.scrape_data[str(job['id'])] = job

# Do not change the order of the next three statements if you want date_filter to work

# stores references to jobs in list to be used in blurb retrieval
scrape_list = [i for i in self.scrape_data.values()]
# converts job date formats into a standard date format
Expand Down
2 changes: 0 additions & 2 deletions jobfunnel/tools/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ def date_filter(cur_dict: Dict[str, dict], number_of_days: int):
del cur_dict[job_id]




def id_filter(cur_dict: Dict[str, dict], prev_dict: Dict[str, dict], provider):
""" Filter duplicates on job id per provider.
Expand Down
2 changes: 1 addition & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ __*Note*__: `rejected` jobs will be filtered out and will disappear from the out
```

* **Filtering Undesired Companies** <br />
Filter jobs that are too old by providing your own `yaml` configuration and adding them to the black list (see `JobFunnel/jobfunnel/config/settings.yaml`).
Filter undesired companies by providing your own `yaml` configuration and adding them to the black list(see `JobFunnel/jobfunnel/config/settings.yaml`).

* **Filtering Old Jobs**<br />
Filter jobs that you think are too old:
Expand Down

2 comments on commit 8cbe28f

@klhyyan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to install by running setup.py in windows. error message cannot find readme.md. can you please help me solve the issue? tried git+ did not work either.

@thebigG
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have pip and python installed on your windows machine?

Please sign in to comment.