pat-inject autoload-visible with IntersectionObserver #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
changed the title
This was referenced Dec 22, 2021
thet
changed the title
thet
force-pushed
the
inject-autoload-visible-intersectionobserver
branch
from
10e69e9 to
e95b66e
Compare
thet
force-pushed
the
inject-autoload-visible-intersectionobserver
branch
from
9d535c0 to
d511b65
Compare
thet
force-pushed
the
master
branch
2 times, most recently
from
e3b2897 to
5060fa4
Compare
… a BBB import. Move utils.getCSSValue to dom.get_css_value and keep a BBB import in utils. This change is made for these reasons: - Avoid circular imports (even if supported). - Code cleanup - move DOM related methods to dom module.
thet
force-pushed
the
inject-autoload-visible-intersectionobserver
branch
from
f72e1ba to
42af77e
Compare
…ement up in the DOM tree.
thet
force-pushed
the
inject-autoload-visible-intersectionobserver
branch
from
42af77e to
ba8b978
Compare
thet
force-pushed
the
inject-autoload-visible-intersectionobserver
branch
from
ba8b978 to
d446771
Compare
…ver. The autoload-visible trigger of pat-inject now uses an IntersectionObserver. This simplifies the code and improves performance because there are no more complex position calculations involved. Fixes: #955
thet
force-pushed
the
inject-autoload-visible-intersectionobserver
branch
from
d446771 to
4f26006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pat-inject autoload visible: use intersection observer to not load too items out of viewport.
Attempt to fix #939
Alternative approach: #942
Fixes: #955