Skip to content

Add support for "Zealous Inquisition" explode mod (Witchhunter Ascendancy Notable) #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

majochem
Copy link
Contributor

Description of the problem being solved:

  • Add support for "Zealous Inquisition" explode mod (Witchhunter Ascendancy Notable)
    • "10% chance for enemies you kill to explode, dealing 100% of their maximum life as physical damage"

Limitations

  • "Chance is doubled against Undead and Demons" not supported yet, as we don't currently support enemy-type specific mods afaik
  • Explosion damage isn't calculated correctly as that seems to be broken for all monster explosion skills in PoB2. E.g. it just takes the base damage of the weapon instead of % of monster life and it also appears to be using "Punch" in the background (need to look into that further)

After screenshot:

image

@majochem majochem marked this pull request as ready for review April 23, 2025 11:19
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label May 1, 2025
@LocalIdentity LocalIdentity merged commit 2a2afd4 into PathOfBuildingCommunity:dev May 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants