This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Implement FMLServerAboutToStartEvent and hooks related to it. #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cittyinthecloud
changed the title
TheGlitch76
suggested changes
Jun 20, 2020
...cycle/src/main/java/net/patchworkmc/mixin/event/lifecycle/MixinMinecraftDedicatedServer.java
Show resolved
Hide resolved
| @Mixin(MinecraftDedicatedServer.class) | ||
| public class MixinMinecraftDedicatedServer { | ||
| @Inject(method = "setupServer", at = @At(value = "INVOKE", target = "Lnet/minecraft/util/UserCache;setUseRemote(Z)V", shift = At.Shift.AFTER)) | ||
| private void onServerAboutToStart(CallbackInfoReturnable<Boolean> cir) { |
There was a problem hiding this comment.
Use a normal CallbackInfo for this
ZNixian
reviewed
Jun 20, 2020
| @@ -11,6 +11,9 @@ | |||
| "MixinClientWorld", | |||
| "MixinMinecraftClient" | |||
There was a problem hiding this comment.
Sorry, missed the boat on this PR. Shouldn't MixinIntegratedServer be included here? I can't see it in any of the Mixin JSON files.
There was a problem hiding this comment.
Good catch! I will fix right now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements FMLServerAboutToStartEvent, and some other calls that happen in forge at the same time (mostly related to passing the MinecraftServer object around). It also creates a stub version of ServerLifecycleHooks that only implements getCurrentServer, which completes part of #84