Consolidate web samples #7894
Merged
Consolidate web samples #7894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t tags from the code
…tion of in endpoint configuration
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates multiple web sample projects (asp-web-application, asp-mvc-application, send-from-aspnetcore-webapi, and blazor-server-application) into a single comprehensive sample that demonstrates sending messages from ASP.NET web applications using various frameworks.
Key Changes:
- Consolidated four separate samples into one unified sample at
samples/web/asp-web-application - Added support for MVC, Web API, Razor Pages, and Blazor in a single project
- Removed dependency on NServiceBus.Callbacks package (simplified to one-way messaging)
- Updated documentation to reflect the consolidated approach
Reviewed Changes
Copilot reviewed 187 out of 199 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/web/asp-web-application/sample.md | Updated documentation to describe the consolidated sample with all frameworks |
| samples/web/asp-web-application/Core_/WebApp/ | New consolidated web application with examples for all ASP.NET frameworks |
| samples/web/asp-web-application/Core_/Server/ | Simplified message handler that logs received messages |
| samples/web/send-from-aspnetcore-webapi/* | Removed - functionality consolidated into main sample |
| samples/web/asp-mvc-application/* | Removed - functionality consolidated into main sample |
| samples/web/blazor-server-application/* | Removed - functionality consolidated into main sample |
| nservicebus/upgrades/5to6/* | Updated cross-references to point to consolidated sample |
| nservicebus/hosting/service-fabric-hosting/* | Updated cross-references to point to consolidated sample |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
|
@ngallegos I've opened a new pull request, #7906, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Fix grammar and formatting issues in sample.md Co-authored-by: ngallegos <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ngallegos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result of
All of the web samples did the same thing, but were inconsistent. This aims to consolidate them into one sample that shows how to send a message from a web application, regardless of framework.