Allow disabling unrestricted delay delivery #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauroservienti
changed the title
mauroservienti
approved these changes
Mar 27, 2025
lailabougria
approved these changes
Mar 27, 2025
…rimental constructor
Co-authored-by: Laila Bougria <[email protected]>
Co-authored-by: Mauro Servienti <[email protected]>
danielmarbach
force-pushed
the
disable-delayed-delivery
branch
from
6c308e4 to
d64f1e8
Compare
danielmarbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2161
It appears that adding optional parameters can be a binary breaking change in some scenarios, but it is not a source breaking change. We considered the drop-in replacement of the transport a non-starter and decided to go with an optional parameter on the existing constructors.