Creating convert.copernicusmarine_to_sgrid() function #2477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is not needed, now that we require users to provide field names explicitly
Since units has been removed as part of #2459
By looking at whether a version of "degrees" is present in units. Before this, "degrees_east" was for example not recognised
VeckoTheGecko
approved these changes
Jan 15, 2026
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
I made
coordsan optional argument. This simplifies using the function
yes - I think in future we'll need to have a think about what the API for all these convert functions look like. We'll see as we do more :)
I also extended the
_is_coordinate_in_degrees()function to just check whether the word degree is part of the units. This will also capture the copernicusmarine case, where units aredegrees_east
Looks good.
Minor feedback - happy to merge once that's addressed and we have green ticks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replicates #2460 by creating a
convert.copernicusmarine_to_sgrid()functionSince the coordinates of copernicusmarine datasets are much more predictable (always
time,depth,latitudeandlongitudeform the copernicusmarine toolbox), I madecoordsan optional argument. This simplifies using the functionI also extended the
_is_coordinate_in_degrees()function to just check whether the word degree is part of the units. This will also capture the copernicusmarine case, where units aredegrees_eastThis PR is part of #2003