-
Notifications
You must be signed in to change notification settings - Fork 168
Implementing View for KernelParticle/ParticleSet #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erikvansebille
wants to merge
8
commits into
v4-dev
Choose a base branch
from
fix_kernelparticle_bug
base: v4-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure shapes stay consistent for single-face queries, and adds a small safeguard against zero norms
erikvansebille
commented
Dec 24, 2025
|
|
||
| class KernelParticle: | ||
| """Simple class to be used in a kernel that links a particle (on the kernel level) to a particle dataset.""" | ||
| class ParticleSetView: |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this particle.py file the best place for the ParticleSetView and ParticleSetViewArray classes? Or better to move them to particle.py; or its own file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2143 by creating a
ParticleSetViewclass that links a View of the ParticleSet (on the kernel level) to a ParticleSet.This allows much more intuitive masking in Kernels, see e.g. the change in the Argo and the interaction tutorials.
For example, some of the old code for the
MergeKernel in the interaction tutorial wasWhile the new code is
Note that this PR is blocked by #2444 (fix cherry-picked into this PR as 9aa0f32)