Making particle-particle interaction tutorial v4-compatible #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not yet touching the Interaction kernels themselves...
Introducing Pull as normal Kernel (but not performance-optimised yet)
Implementing some suggestions by GenAI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows how to use 'simple'/standard kernels for particle-particle interaction in v4.
Now that Kernels have access to all particles, it is fairly straightforward to write both the
Pulland theMergekernel in vectorised form (barring the KernelParticle bug in #2143).This means that we don't need all the machinery for InteractionParticles, so that can all be removed from the codebase
This PR implements #2396