Skip to content

changed main to def#1

Open
Parameshkumar22 wants to merge 1 commit into
main2from
main
Open

changed main to def#1
Parameshkumar22 wants to merge 1 commit into
main2from
main

Conversation

@Parameshkumar22

Copy link
Copy Markdown
Owner

No description provided.

Comment thread src/App.js
import { CheckCircleTwoTone } from '@ant-design/icons';
import Card from './Card'
import { Progress } from 'antd';
import Hi from './Practice';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give proper name

Comment thread src/App.js
<Input className='input' maxLength={21}
placeholder="Enter 21-Digit-CIN" />
<div className='circle'>
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use constant file for this

Comment thread src/App.js


<div className='button1'>
<button type="submit" className="button" onSubmit={submithandler}>Proceed</button>

@chougulenikita chougulenikita Mar 14, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/App.js
<button type="submit" className="button" onSubmit={submithandler}>Proceed</button>

</div>
<div className='card'>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/App.js



<p className = 'subhead'> Credit limit available &nbsp; : </p>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/App.css
position: absolute;
width: 236px;
height: 784px;
left: 0px;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for css u use styled component also
https://www.npmjs.com/package/styled-components

Comment thread src/Drop.js

return (
<div style={{
display: 'block', width: 700, padding: 30

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove inline css and use styled-component or className

Comment thread src/Drop.js
<div style={{
display: 'block', width: 700, padding: 30
}}>
<h4>ReactJS Ant-Design Select Component</h4>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use antd typography for heading

Comment thread src/Dropdown.css
@@ -1,74 +0,0 @@
.select {
box-sizing: border-box;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why u make separate css file for all

Comment thread src/Dropdown.js
import { InputNumber } from 'antd';
import { Select } from 'antd';
function DropdownInput({ options }) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/Dropdown.js
{showOptions && (
<ul
style={{
position: 'absolute',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove inline css

Comment thread src/Practice.js

}}
>
<p> profit Margin</p>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use typography

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants