Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic text for instruction text #10942

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

iamhks
Copy link
Contributor

@iamhks iamhks commented Mar 2, 2025

Description

Fixes #10072
Made code changes to support dynamic text for votes help tool tip & reflections help tool tip
Adding screenshots:

  • When Anonymous is checked:
Screenshot 2025-03-05 at 03 09 58
  • When Anonymous is un-checked:
Screenshot 2025-03-05 at 03 10 33
  • Vote Settings(opening in 2 tabs to show both settings and instruction text):
Screenshot 2025-03-05 at 03 12 50

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@github-actions github-actions bot requested a review from mattkrick March 2, 2025 20:04
@Dschoordsch
Copy link
Contributor

@iamhks You missed some part of the issue: "retro reflection phase always says it's anonymous"

@iamhks
Copy link
Contributor Author

iamhks commented Mar 4, 2025

Oh yes! I'll keep the text anonymous if that setting is enabled and remove the line if the setting is disabled.
Does that work @Dschoordsch or do you have any alternate suggestion?

@Dschoordsch
Copy link
Contributor

That would be good.

@iamhks
Copy link
Contributor Author

iamhks commented Mar 4, 2025

Hi @Dschoordsch, please have a look. Updated the screenshots as well.

@iamhks
Copy link
Contributor Author

iamhks commented Mar 7, 2025

FYI: I'll be out of station for about a week and a half, will be able to resolve any comments after I am back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix retro phase instruction text
2 participants