fix: update icebreaker styles #10723
Merged
+11
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickoferrall
commented
Jan 22, 2025
| @@ -37,30 +37,6 @@ const CogIcon = styled('div')({ | |||
| width: 24 | |||
| }) | |||
|
|
|||
| const QuestionBlock = styled('div')({ | |||
There was a problem hiding this comment.
While in the area, I changed this to tailwind. It's not directly relevant to the icebreaker styles
|
Hey @ackernaut, are you free to review this PR? |
ackernaut
approved these changes
Feb 4, 2025
| display: 'flex', | ||
| flexDirection: 'column', | ||
| fontSize: 24, | ||
| lineHeight: 1.25, |
There was a problem hiding this comment.
Nit: I would bump this line-height (1.25) from 30px to 32px. 30px is a little too tight to my eyes. 36 is too much. Might at well use px units with fontSize: 24.
|
Thanks, I've bumped the line height 👍
|
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10683
Demos:
To test