Render stroke-only custGeom line shapes#150
Merged
Merged
Conversation
Thin decorative rules built as a custom-geometry line segment (moveTo + lnTo) with a stroke and no fill were dropped: ParseSolidFillShape bailed whenever a shape had no fill, and ExtractSubpaths discarded contours with fewer than three points. The Agenda template's left/top accent rules (agendas-minutes/10) went missing across every backend as a result. Emit a stroke-only FloatingShapeElement when a shape has a stroke but no fill, carrying its flattened Subpaths (open two-point contours kept via a new minContourPoints). All backends already stroke Subpaths, so Skia, ImageSharp, PDF and the HTML export pick it up unchanged. Filled shapes keep the three-point minimum and never gain an outline, so their output stays byte-identical. Gate the new path to solid dashes: a dashed outline drawn solid looks worse than not drawing it (matching ParseLineShape), so letterhead decorations like letters/05's dashed rules stay unrendered rather than becoming solid bars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thin decorative rules built as a custom-geometry line segment (moveTo + lnTo) with a stroke and no fill were dropped: ParseSolidFillShape bailed whenever a shape had no fill, and ExtractSubpaths discarded contours with fewer than three points. The Agenda template's left/top accent rules (agendas-minutes/10) went missing across every backend as a result.
Emit a stroke-only FloatingShapeElement when a shape has a stroke but no fill, carrying its flattened Subpaths (open two-point contours kept via a new minContourPoints). All backends already stroke Subpaths, so Skia, ImageSharp, PDF and the HTML export pick it up unchanged. Filled shapes keep the three-point minimum and never gain an outline, so their output stays byte-identical.
Gate the new path to solid dashes: a dashed outline drawn solid looks worse than not drawing it (matching ParseLineShape), so letterhead decorations like letters/05's dashed rules stay unrendered rather than becoming solid bars.