Add root/admin user warning #693
Conversation
| + private static final boolean RUNNING_AS_ROOT_OR_ADMIN; | ||
| + | ||
| + static { | ||
| + boolean isWindows = System.getProperty("os.name").startsWith("Windows"); |
There was a problem hiding this comment.
tabs 😢
Does this implement the fixed check from the new PR?
There was a problem hiding this comment.
Java 8 (or at least in Waterfall's setup) doesn't seem to like the NTSystem/UnixSystem classes, so I used the "running a command" method from the start, so this isn't affected by the OpenJDK bug.
I think this is useless, since most people don't have access to SSH, and those who do have access already have some experience, it seems to me that adding a warning for that is redundant. |
It is not redundant. I believe many people running a server network do have a vserver/vps or root server rented, because they're often cheaper compared to multiple single mc servers. |
|
I dont like the way you doing it i would use io.netty.util.internal.PlatformDependent#maybeSuperUser() instead if your reg check and creating processes, this should be enought |
5 participants
This PR ports the root detection introduced in PaperMC/Paper#2432 (and re-added in PaperMC/Paper#6593) to Waterfall. The implementation used in PaperMC/Paper#6593 doesn't seem to work on Java 8, so I've used a slightly different check.
Tested on macOS and Windows 10.