Allow responding to cookie requests #1453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luccboy
approved these changes
Oct 28, 2024
|
Need to update the toString inside of the event |
|
Applied the requested changes |
astei
requested changes
Dec 26, 2024
| @@ -68,15 +69,19 @@ public String toString() { | |||
| */ | |||
| public static final class ForwardResult implements Result { | |||
There was a problem hiding this comment.
I would much prefer a separate RespondResult here.
There was a problem hiding this comment.
Then it wouldn't make sense with getResult(). Also, since we're responding on behalf of the player, we also answer on how this should be forwarded, as we can't allow 2 responses (and the client always responds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a server is awaiting the cookie response, it is impossible to block the request without forcing the server to wait indefinably, as https://jd.papermc.io/velocity/3.4.0/com/velocitypowered/api/event/player/CookieRequestEvent.ForwardResult.html#handled() just discards any requests without sending any responses and there is no api to manually send a response.
The current approach is similar to https://jd.papermc.io/velocity/3.4.0/com/velocitypowered/api/event/player/ServerLoginPluginMessageEvent.html, but if you consider that instead of this, it would be better to add a method in https://jd.papermc.io/velocity/3.4.0/com/velocitypowered/api/proxy/ServerConnection.html to send a response then I would change it