fix: Player#setPlayerTime sends time update packet to client #13315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
approved these changes
Nov 18, 2025
Contributor
lynxplay
left a comment
lynxplay
left a comment
There was a problem hiding this comment.
Generally LGTM, a bit annoying that we have this logic now duplicated from the general update flow in MinecraftServer but I don't think we can nicely extract that out, given the MinecraftServer logic has some allocation improvements that would make extraction less than ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Player#setPlayerTime only updates fields timeOffset and relativeTime,
which means the client may not immediately reflect the new time. This PR ensures that whenever
setPlayerTime is called, a ClientboundSetTimePacket is sent to the player so the client is synced immediately.