Skip to content

Conversation

@Doc94
Copy link
Member

@Doc94 Doc94 commented Nov 8, 2025

@Toffikk
Copy link

Toffikk commented Nov 8, 2025

maybe it'd be better to rename the class to something like Validations or ValuePreconditions? it could also be FloatPreconditions or smth but not sure if there aren't more types planned to be added to this...

@Doc94 Doc94 changed the title Change validation for floats Improvements checks for arguments numbers Nov 9, 2025
@Doc94
Copy link
Member Author

Doc94 commented Nov 9, 2025

maybe it'd be better to rename the class to something like Validations or ValuePreconditions? it could also be FloatPreconditions or smth but not sure if there aren't more types planned to be added to this...

i think the idea is add more checks.. but i found another class with similar use.. then i move to this for now.

@Doc94 Doc94 marked this pull request as ready for review November 11, 2025 02:13
@Doc94 Doc94 requested a review from a team as a code owner November 11, 2025 02:13
Copy link
Member

@jpenilla jpenilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asArgument[Condition] -> require[Condition]

This follows the pattern of Objects.requireNonNull, etc.

@github-project-automation github-project-automation bot moved this from Awaiting review to Changes required in Paper PR Queue Nov 11, 2025
@Doc94
Copy link
Member Author

Doc94 commented Nov 11, 2025

asArgument[Condition] -> require[Condition]

This follows the pattern of Objects.requireNonNull, etc.

only the asArgument methods not? also.... what about requireArgument (ex: requireArgumentMin, requireArgumentRange) for make clear its intended for Arguments.

@Doc94 Doc94 force-pushed the feature/floats-checks branch from 09fb1f1 to c643f5e Compare November 13, 2025 14:17
@Doc94 Doc94 requested a review from jpenilla November 14, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Changes required

Development

Successfully merging this pull request may close these issues.

3 participants