fix(report): clarify plan comparison — negative remaining and Used% column - #91
Closed
PanAchy wants to merge 1 commit into
Closed
fix(report): clarify plan comparison — negative remaining and Used% column#91PanAchy wants to merge 1 commit into
PanAchy wants to merge 1 commit into
Conversation
… % column The previous report was confusing when usage exceeded the plan limit: - Remaining hid the negative sign via Math.abs (showed 55.9 when actually -55.9) - The column header was ambiguous (just '%') Now: - Remaining shows negative values directly when over budget - Column renamed to 'Used %' showing the usage ratio (105.6% vs -5.6%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: Remaining hid negative values (overage looked like surplus) and column was just a vague percent. Now: Remaining shows negatives directly, column renamed to Used percent. The tester of PR 88 flagged this in issue 87.