Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding ability to enable instance monitoring #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ntwrkguru
Copy link
Contributor

Description

Motivation and Context

Expose the provider's ability to enable instance monitoring. Prior to this PR it is hardcoded to false.

How Has This Been Tested?

local

Screenshots (if appropriate)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@ntwrkguru ntwrkguru requested a review from a team as a code owner August 29, 2024 20:00
Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍
Do you want to add similar feature for panorama module ?

@github-actions github-actions bot added the stale label Oct 22, 2024
@migara
Copy link
Member

migara commented Jan 15, 2025

/apply paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 12787223811
Job result: FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants