-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elemental model changes to use mongo-go-driver's bson types instead of mgo #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f using those of mgo.
…ller interface that's needed by mongo-go-driver
knainwal
changed the title
elemental model changes to use mongo-go-driver's bson types instead o…
elemental model changes to use mongo-go-driver's bson types instead of mgo
Aug 6, 2024
sawyerawesome
previously approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Sawyer! |
sawyerawesome
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use of mgo required generating code for spec files that implemented GetBSON and SetBSON methods, while using mongo-go-driver requires different way of marshaling/unmarshaling data to/from mongo (by implementing MarshalBSON/UnmarshalBSON methods).
Motivation and Context
This change is required so that generated golang code by elegen is compatible with mongo-go-driver for interfacing with latest mongoDB versions.
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist