Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elemental model changes to use mongo-go-driver's bson types instead of mgo #135

Merged
merged 10 commits into from
Aug 22, 2024

Conversation

knainwal
Copy link
Contributor

@knainwal knainwal commented Jul 15, 2024

Description

Use of mgo required generating code for spec files that implemented GetBSON and SetBSON methods, while using mongo-go-driver requires different way of marshaling/unmarshaling data to/from mongo (by implementing MarshalBSON/UnmarshalBSON methods).

Motivation and Context

This change is required so that generated golang code by elegen is compatible with mongo-go-driver for interfacing with latest mongoDB versions.

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@knainwal knainwal changed the title elemental model changes to use mongo-go-driver's bson types instead o… elemental model changes to use mongo-go-driver's bson types instead of mgo Aug 6, 2024
@knainwal knainwal self-assigned this Aug 6, 2024
sawyerawesome
sawyerawesome previously approved these changes Aug 7, 2024
Copy link

@sawyerawesome sawyerawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knainwal
Copy link
Contributor Author

knainwal commented Aug 7, 2024

LGTM

Thanks Sawyer!

@knainwal knainwal removed the request for review from malkhamis-panw August 7, 2024 16:53
Copy link

@sawyerawesome sawyerawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knainwal knainwal merged commit 6f8c7be into master Aug 22, 2024
3 checks passed
@knainwal knainwal deleted the elemental-mongo70-poc branch August 22, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants