Skip to content

Modify konnectors' job and chart name to better align with conventions #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yishaynaPalo merged 4 commits into from
Jan 5, 2026
Merged

Modify konnectors' job and chart name to better align with conventions #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2ee030
Modify konnectors' job and chart name to better align with conventions
oded7hoffman Jan 2, 2026
ebe3ff4
Return the name of the helm chart to konnector
oded7hoffman Jan 4, 2026
71cc328
Merge branch 'release/cloud-1.4' into ohoffman/alineNamingConventions
oded7hoffman Jan 4, 2026
fef8c81
Changing konnector job name to cortex-syncer
oded7hoffman Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/konnector/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: konnector
description: Deploys Palo Alto Networks' Cortex KSPM connector for advanced Kubernetes security posture management.
type: application
version: 1.0.24-rc.6
version: 1.0.24-rc.7
appVersion: "1.0.0"
maintainers:
- name: Palo Alto Networks - Cortex KSPM team
Expand Down
4 changes: 2 additions & 2 deletions charts/konnector/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ spec:
secretName: {{ .Values.system.secrets.backendAuth.name }}
serviceAccountName: {{ .Values.system.serviceAccount.name }}
containers:
- name: {{ .Chart.Name }}
- name: {{ .Values.system.batch.name }}
image: "{{ .Values.image.repository }}/{{ .Values.image.name }}{{- if .Values.image.tag }}:{{ .Values.image.tag }}{{- end }}{{- if .Values.image.digest }}@{{ .Values.image.digest }}{{- end }}"
resources:
{{- toYaml .Values.system.apps.resources | nindent 12 }}
command: [/{{ .Chart.Name }}]
command: [/konnector]
env:
- name: NAMESPACE
valueFrom:
Expand Down
6 changes: 3 additions & 3 deletions charts/konnector/templates/batch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
apiVersion: batch/v1
kind: Job
metadata:
name: "{{ .Chart.Name }}-job-revision-{{ .Release.Revision }}"
name: "{{ .Values.system.batch.name }}-job-revision-{{ .Release.Revision }}"
namespace: {{ .Values.namespace.name }}
labels:
{{- include "common.labels" . | nindent 4 }}
Expand All @@ -13,7 +13,7 @@ metadata:
apiVersion: batch/v1
kind: CronJob
metadata:
name: {{ .Chart.Name }}
name: {{ .Values.system.batch.name }}
namespace: {{ .Values.namespace.name }}
labels:
{{- include "common.labels" . | nindent 4 }}
Expand All @@ -26,7 +26,7 @@ spec:
apiVersion: batch/v1
kind: Job
metadata:
name: delete-{{ .Values.system.K8sManager.ReleaseName }}
name: delete-{{ .Values.system.batch.name }}
namespace: {{ .Values.namespace.name }}
annotations:
"helm.sh/hook": pre-delete
Expand Down
1 change: 1 addition & 0 deletions charts/konnector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ system:
batch:
backoffLimit: 4 # Maximum number of retries before the job is considered failed. After 4 attempts, the job will fail.
ttlSecondsAfterFinished: 3600 # Time-to-live for completed jobs, jobs will be automatically deleted 3600 seconds (1 hour) after completion
name: "cortex-syncer"
cleanupJob:
resources:
requests:
Expand Down