Skip to content

Conversation

@jfmontufar
Copy link

@jfmontufar jfmontufar commented Oct 10, 2025

Description

I've added the following features:

  • The capability to use a private image for the delete Job of the chart k8s-connector-release
  • Make optional the creation of secrets of konnector-docker-secret and distribution-id

Motivation and Context

Since currently the Job for deleting the k8s-connector-release helm chart uses a public image, due to compliance requirements, I've added the capacity to use its own image stored in private registry by adding the following values:

deleteJob:  # These values correspond to a Job used for deleting resources
  image:
    repository: "docker.io" # Repository where the image of is stored
    name: "alpine/helm"  # Name of the image to be used
    tag: "3.17.2"   # Tag for the image
    digest: ""        # Image digest (optional)
  secret:
    reuse: false  # Reuse the pull secret from the KSPM Connector
    create: false  # Create Secret to pull the deleteJob image. Set to true if not being exported from external vault
    dockerPullSecret:  # Value of the pull secret if create is set to true and reuse to false
    name:  # Name of the secret to  pull the deleteJob

As noticed this by default still uses the public image alpine/helm:3.17.2

Additionally, since for security purposes, some customers require to use a vault to store the secrets, therefore I've made the creation of the secrets konnector-docker-secret and distribution-id optional so this values can be retrieved from external sources, by introducing the following values:

createPullSecret: true  # Create secret to pull images. Set to false if the secret is being created from external source

distribution:
  createSecret: true  # Create the secret corresponding to the distribuition id. Set to false if the secret is being created from external source 

How Has This Been Tested?

It has been tested using EKS and Jfrog to store the alpine/helm:3.17.2 image

Screenshots

Using Private Image for Delete Job

values file:
image

Uninstall Job with created Secret:
image

Uninstallation Successful:
image

Tested with and without creation of the dockerPullSecret for the delete Job.

Optional creation of secrets

Secrets of konnector-docker-secret and distribution-id already exist:
image

Values file without distribution.id and dockerPullSecret:
image

Successful installation:
image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant