Feat: Update delete Job image and the secrets konnector-docker-secret & distribution-id #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added the following features:
Motivation and Context
Since currently the Job for deleting the k8s-connector-release helm chart uses a public image, due to compliance requirements, I've added the capacity to use its own image stored in private registry by adding the following values:
As noticed this by default still uses the public image
alpine/helm:3.17.2Additionally, since for security purposes, some customers require to use a vault to store the secrets, therefore I've made the creation of the secrets konnector-docker-secret and distribution-id optional so this values can be retrieved from external sources, by introducing the following values:
How Has This Been Tested?
It has been tested using EKS and Jfrog to store the alpine/helm:3.17.2 image
Screenshots
Using Private Image for Delete Job
values file:

Uninstall Job with created Secret:

Uninstallation Successful:

Tested with and without creation of the dockerPullSecret for the delete Job.
Optional creation of secrets
Secrets of konnector-docker-secret and distribution-id already exist:

Values file without distribution.id and dockerPullSecret:

Successful installation:

Types of changes
Checklist