fix: mixpanel initialize configuration

Pagnet · Feb 15, 2024 · 03c11d6 · 03c11d6
1 parent 52c6733
commit 03c11d6
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 12 deletions.
diff --git a/src/dispatchers/dispatchers.types.ts b/src/dispatchers/dispatchers.types.ts
@@ -1,9 +1,9 @@
 export type EventType = 'customEvent' | 'screenEvent' | 'userIdentification';
-export type PropertiesType = { [key: string]: string };
+export type PropertiesType = { [key: string]: string | boolean | number | string[] | undefined; };
 export type UserPropertiesType = {
   email?: string;
   name?: string;
-  [key: string]: string | undefined;
+  [key: string]: string | boolean | number | any[] | undefined;
 };
 export type EventData = {
   screen?: string;

diff --git a/src/initializers/index.ts b/src/initializers/index.ts
@@ -55,9 +55,7 @@ const mixPanelInitializer = (
 ): void => {
   if (isProduction(environment)) {
     localStorage.setItem('_bl_mp', apiKey);
-    mixpanel.init(apiKey, {
-      track_pageview: true,
-    });
+    mixpanel.init(apiKey);
     localStorage.removeItem('_bl_init');
   }
 };

diff --git a/src/providers/setups/mixpanel/mixpanel.spec.ts b/src/providers/setups/mixpanel/mixpanel.spec.ts
@@ -33,11 +33,13 @@ describe('MixPanelProvider', () => {
 
   test('dispatchCustomEvent should call mixpanel.track with event and properties', () => {
     const event = 'testEvent';
-    const properties = { key1: 'value1', key2: 'value2' };
+    const properties = {
+      key1: 'value1', key2: true, key3: 9.9, key4: ['value1', 'value2'],
+    };
 
     MixPanelProvider.customEvent(event, properties);
-
-    expect(mixpanel.track).toHaveBeenCalledWith(event, { properties });
+    const { ...rest } = properties;
+    expect(mixpanel.track).toHaveBeenCalledWith(event, rest);
   });
 
   test('dispatchScreenEvent should call mixpanel.track with screen', () => {

diff --git a/src/providers/setups/mixpanel/mixpanel.ts b/src/providers/setups/mixpanel/mixpanel.ts
@@ -35,7 +35,8 @@ const dispatchCustomEvent = (
   event: string,
   properties: PropertiesType,
 ): void => {
-  mixpanel.track(event, { properties });
+  const { ...rest } = properties;
+  mixpanel.track(event, rest);
 };
 
 const dispatchScreenEvent = (screen: string): void => {

diff --git a/src/utils/index.ts b/src/utils/index.ts
@@ -12,9 +12,7 @@ export const checkIfMixPanelIsInitialized = (provider: string): void => {
     const wasInitialized = localStorage.getItem('_bl_init');
 
     if (!wasInitialized) {
-      mixpanel.init(apiKey, {
-        track_pageview: true,
-      });
+      mixpanel.init(apiKey);
       localStorage.removeItem('_bl_mp');
       localStorage.setItem('_bl_init', 'init');
     }