-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Remove backend argument of init_parallel_env #26773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove backend argument of init_parallel_env #26773
Conversation
|
Thanks for your contribution! |
| # directly, if they want to switch default place, | ||
| # they need to call a function to change default place, | ||
| # here just set correctly place to users | ||
| place = core.CUDAPlace(ParallelEnv().device_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I call this function with CPU whl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, add cuda check for this function
XiaoguangHu01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
guru4elephant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think init_parallel_env() can be used in CPU whl, the difference is we init gloo related functions. For GPU whl, we'd better init both nccl and gloo for compatibility of cpu/gpu collective operators. @sandyhouse @chenwhql please improve this function in the following updates.
thx, of course, we should support init CPU parallel env in this function later |
XiaoguangHu01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jzhang533
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR types
Function optimization
PR changes
APIs
Describe
Remove backend argument of init_parallel_env, reason:
related PR: #26044