-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for DeepVariant 1.6.0 #85
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- custom models are now provided as `custom_deepvariant_model_tar` - `custom_deepvariant_model_tar` is documented in README - disabled threaded io for `deepvariant_postprocess_variants` until we investigate memory requirements
williamrowell
force-pushed
the
feature/deepvariant-1.6
branch
from
November 13, 2023 22:07
f9b945c
to
41fa4d3
Compare
Conflicts: workflows/wdl-common
Update pbmm2 to v1.13
williamrowell
requested review from
juniper-lake
and removed request for
juniper-lake
December 11, 2023 21:39
gconcepcion
approved these changes
Dec 11, 2023
juniper-lake
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
williamrowell
force-pushed
the
develop
branch
2 times, most recently
from
December 14, 2023 23:22
053c0b9
to
9e63d4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom_deepvariant_model_tar
custom_deepvariant_model_tar
is documented in READMEdeepvariant_postprocess_variants
until we investigate memory requirementsDepends on PacificBiosciences/wdl-common#32