Review June 2020#26

Open

mads-bertelsen wants to merge 461 commits intoreview/project_review_june_2020from

This pull request is big! We're only showing the most recent 250 commits

Commits on Jan 6, 2022

Added name and on condition.
Mads Bertelsen
committed
Getting indentation right
Mads Bertelsen
committed
Added colon
Mads Bertelsen
committed
Small changes to syntax
Mads Bertelsen
committed
removed name
Mads Bertelsen
committed
Removed mmap from requirements as its a default package
Mads Bertelsen
committed
Removed demo
Mads Bertelsen
committed
installed pytest
Mads Bertelsen
committed
Show file structure to ensure all folders are present
Mads Bertelsen
committed
Updated show_categories so that their output is in alphabetic order.
Mads Bertelsen
committed
Missed a file in last commit.
Mads Bertelsen
committed
Attempting to add windows to the text matrix
Mads Bertelsen
committed
Fixed unit test that would fail on windows due to hardcoded slash
Mads Bertelsen
committed
Fixed mistake in workflow that caused unix part not to run.
Mads Bertelsen
committed
Added macos and cache system to unittest workflow
Mads Bertelsen
committed
Moved to find instead of tree to show files to ensure compatability
Mads Bertelsen
committed
tree . on windows and unix
Mads Bertelsen
committed
reorder lines for if
Mads Bertelsen
committed
made comparisons strings
Mads Bertelsen
committed
Changed to one workflow per operating system.
Mads Bertelsen
committed
Merge pull request #41 from PaNOSC-ViNYL/github_actions
mads-bertelsen
authored
Merge branch 'master' into mcstasscript_on_libpyvinyl
mads-bertelsen
authored
Checking checkout of libpyvinyl on workflow
Mads Bertelsen
committed
Trying libpyvinyl build first, then mcstasscript
Mads Bertelsen
committed
Forgot checkout of libpyvinyl
Mads Bertelsen
committed
All workflows now get libpyvinyl develop from github.
Mads Bertelsen
committed
Fix of indentation error on ubuntu workflow
Mads Bertelsen
committed
Added note on unused threading.
Mads Bertelsen
committed
Updates to test workflows so developer version of libpyvinyl is used
Mads Bertelsen
committed
Removed cache from libpyvinyl install
Mads Bertelsen
committed
setting up a path for each library.
Mads Bertelsen
committed
Trying to cd into libpyvinyl and mcstasscript folders
Mads Bertelsen
committed
Changed directory structure of workflows.
Mads Bertelsen
committed
Changed directory to avoid python setup getting requirements
Mads Bertelsen
committed

Commits on Jan 12, 2022

Started sphinx documentation
Mads Bertelsen
committed

Commits on Mar 15, 2022

Updates to documentation, including longer run lengths.
Mads Bertelsen
committed

Commits on Mar 21, 2022

First version of McStasScript working with something very close to
Mads Bertelsen
committed
Change libpyvinyl version in github workflows.
Mads Bertelsen
committed
Update of documentation to reflect that backengine now returns
Mads Bertelsen
committed

Commits on Mar 22, 2022

Updates to documentation. Bug in reading union_histories fixed.
Mads Bertelsen
committed
Included link to documentation in warning.
Mads Bertelsen
committed
Changed version system so it can be found by mcstasscript.
Mads Bertelsen
committed
First version of mcstasscript init.
Mads Bertelsen
committed
Added configurator to __init__
Mads Bertelsen
committed
Update to documentation, now uses simple import.
Mads Bertelsen
committed
Updating tests to run python 3.7 to 3.9
Mads Bertelsen
committed
Fixed bug in version pickup in setup.py
Mads Bertelsen
committed
removed pickle from requirements (its built in, so can't be found)
Mads Bertelsen
committed
Update of readme
Mads Bertelsen
committed
Removed pdf documentation, outdated and not useful anymore.
Mads Bertelsen
committed
Merge branch 'master' into mcstasscript_on_libpyvinyl
mads-bertelsen
authored
Merge pull request #40 from PaNOSC-ViNYL/mcstasscript_on_libpyvinyl
mads-bertelsen
authored
Small typo in setup script.
Mads Bertelsen
committed
Small typo in setup.py
Mads Bertelsen
committed
Update of examples and tutorial.
Mads Bertelsen
committed
Bump of version number.
Mads Bertelsen
committed
Cryostat builder and example notebook added.
Mads Bertelsen
committed
cleared cryostat notebook.
Mads Bertelsen
committed

Commits on Mar 23, 2022

Small fixes from Shervin review.
Mads Bertelsen
committed
Small documentation fixes from Celine. Thanks!
Mads Bertelsen
committed
Update of cryostat_builder: sample -> origin to clarify that it is a point.
Mads Bertelsen
committed

Commits on Apr 22, 2022

Fix of issue where libpyvinyl parameters provided to McStasScript
Mads Bertelsen
committed
Added unit test on case where libpyvinyl parameters given at
Mads Bertelsen
committed
Updated doc strings for new functions
Mads Bertelsen
committed
Merge pull request #43 from PaNOSC-ViNYL/libpyvinyl_par_fix
mads-bertelsen
authored

Commits on Apr 25, 2022

Fixed a bug where components with definition parameters that have double
Mads Bertelsen
committed
Added simple tool for generating NCrystal Union materials.
Mads Bertelsen
committed

Commits on May 5, 2022

Fixed lack of suppress_output in settings.
Mads Bertelsen
committed
Added suppress_output to instrument initialization.
Mads Bertelsen
committed
Version bump
Mads Bertelsen
committed

Commits on May 6, 2022

Merge pull request #44 from PaNOSC-ViNYL/ncrystal_union_tool
mads-bertelsen
authored
Update including fix of setting mpi to None and including gravity in settings.
Mads Bertelsen
committed
Incremented version number, now have mpi and gravity fix.
Mads Bertelsen
committed

Commits on May 10, 2022

Renamed show_components to available_components as it displays
Mads Bertelsen
committed
Removed kwargs in instrument initialization.
Mads Bertelsen
committed

Commits on May 11, 2022

Removed kwargs in show_parameters and print_short on Component.
Mads Bertelsen
committed
Removed methods on instrument for manipulating components.
Mads Bertelsen
committed
Removed widget interface from base McStasScript import to avoid
Mads Bertelsen
committed
Removed component_name_list attribute in instr. It introduced a
Mads Bertelsen
committed
Work in progress on changing component to not have RELATIVE in
Mads Bertelsen
committed
Enabled an error check for references to other components in
Mads Bertelsen
committed
Checks for RELATIVE errors and allows PREVIOUS keyword.
Mads Bertelsen
committed

Commits on May 12, 2022

Code for error checking and remove/move components.
Mads Bertelsen
committed
Clean up of examples, correcting bugs and improving use of syntax.
Mads Bertelsen
committed
Check of all doc notebooks for consitensy.
Mads Bertelsen
committed

Commits on May 13, 2022

making output_path a method of the class and not a member. It is now using the base_dir from the BaseCalculator
Shervin Nourbakhsh
committed

Commits on May 16, 2022

Added feature that allows hiding the new tab from show_instrument
Mads Bertelsen
committed
Version bump to 0.0.44
Mads Bertelsen
committed
Final documentation pass before update 0.0.44.
Mads Bertelsen
committed
Merge pull request #46 from PaNOSC-ViNYL/syntax_cleanup
mads-bertelsen
authored

Commits on May 18, 2022

Merge pull request #45 from PaNOSC-ViNYL/using_basedir
mads-bertelsen
authored
Ensure default name for data depend on instrument name.
Mads Bertelsen
committed
First functional version of instrument diagram.
Mads Bertelsen
committed
Update of instrument diagram, now makes it as wide as it needs to
Mads Bertelsen
committed
Finishing touches on instrument diagram.
Mads Bertelsen
committed
version bump.
Mads Bertelsen
committed
Missing line in doc string.
Mads Bertelsen
committed
Merge pull request #47 from PaNOSC-ViNYL/instrument_diagram
mads-bertelsen
authored

Commits on May 31, 2022

New version of instrument diagram.
Mads Bertelsen
committed

Commits on Jun 7, 2022

Refactor and fix of instrument diagram:
Mads Bertelsen
committed

Commits on Jun 8, 2022

Introduced changes to box outline in diagram to show EXTEND and WHEN keywords being used.
Mads Bertelsen
committed
Updates to documentation, including instrument diagram in tutorial.
Mads Bertelsen
committed

Commits on Jun 10, 2022

Improvements to diagram.
Mads Bertelsen
committed
Updates to documentation.
Mads Bertelsen
committed
Images for documentation.
Mads Bertelsen
committed
Adds quotes around executables to run even when there are spaces in path.
Mads Bertelsen
committed

Commits on Jun 13, 2022

forgot __init__.py file for python module instrument_diagram.
Mads Bertelsen
committed
version bump
Mads Bertelsen
committed

Commits on Jun 16, 2022

Removed print from managed_mcrun.
Mads Bertelsen
committed

Commits on Jun 17, 2022

Adding support for USERVARS which is available in McStas 3.X.
Mads Bertelsen
committed

Commits on Jun 20, 2022

Makes instrument reader handle USERVARS in 3.0 instruments.
Mads Bertelsen
committed
Fixed problem in connections allowing skipping both origin and
Mads Bertelsen
committed
Version bump
Mads Bertelsen
committed
Updates to documentation for v 0.0.50
Mads Bertelsen
committed
Merge pull request #49 from PaNOSC-ViNYL/mcstas_3.0_support
mads-bertelsen
authored

Commits on Sep 8, 2022

Update of reader so it understands keywords in capital and lowercase letters.
Mads Bertelsen
committed

Commits on Sep 27, 2022

First version of MCPL bridge.
Mads Bertelsen
committed
If instrument file not found, it is generated even if force_compile=False
Shervin Nourbakhsh
committed

Commits on Sep 28, 2022

Merge branch 'PaNOSC-ViNYL:master' into master
willend
authored
Fixes to how the MCPL bridge feature is implemented.
Mads Bertelsen
committed

Commits on Sep 29, 2022

Changes to how dumps to and from MCPL work.
Mads Bertelsen
committed

Commits on Sep 30, 2022

Updates for dump database.
Mads Bertelsen
committed
Migrated mcpl filenames to parameters to avoid recompiling
Mads Bertelsen
committed

Commits on Oct 4, 2022

Commits on Oct 10, 2022

Commits on Oct 13, 2022

Cleanup of MCPL bridge system, including more doc strigns and checks.
Mads Bertelsen
committed

Commits on Oct 14, 2022

Refactor of BeamDumpDatabase newest_at_point and
Mads Bertelsen
committed
Merge pull request #56 from PaNOSC-ViNYL/bridge_with_MCPL
mads-bertelsen
authored
Fix of component print code and associated unittests.
Mads Bertelsen
committed

Commits on Oct 17, 2022

Version bump, now version 0.0.51, updates to documentation for MCPL bridge.
Mads Bertelsen
committed

Commits on Oct 25, 2022

Small fixes:
Mads Bertelsen
committed

Commits on Oct 26, 2022

Initial implementation of debugging tool that place event monitors
Mads Bertelsen
committed

Commits on Oct 27, 2022

New feature, diagnostics tool can now plot intensity and ray evolution
Mads Bertelsen
committed

Commits on Oct 31, 2022

Update of diagnostics, common aspects of a diagnostics instrument
Mads Bertelsen
committed

Commits on Nov 1, 2022

Fixed bug with GROUP label in diagrams, the last GROUP name was
Mads Bertelsen
committed

Commits on Nov 4, 2022

mcpl file path added to output collection, mcpl input added to MCPL_input component filename
Shervin Nourbakhsh
committed
make the mcpl methods for internal use only
Shervin Nourbakhsh
committed
data collection taking the name from the calculator name
Shervin Nourbakhsh
committed
Update of CI workflows for new version of libpyvinyl
Mads Bertelsen
committed
Going to libpyvinyl master for CI builds.
Mads Bertelsen
committed
Merge pull request #53 from PaNOSC-ViNYL/mcpl_input_output
mads-bertelsen
authored

Commits on Nov 14, 2022

Update of diagnostics tools, they now support:
Mads Bertelsen
committed

Commits on Nov 15, 2022

Update of data with ability to use flag info to set axis when
Mads Bertelsen
committed
Update of CI workflows for new version of libpyvinyl
Mads Bertelsen
committed
Going to libpyvinyl master for CI builds.
Mads Bertelsen
committed

Commits on Nov 17, 2022

Final update of diagnostics system. Now checks if McStas / McXtrace
Mads Bertelsen
committed
Fix of index.rst typo.
Mads Bertelsen
committed
Fixed tests for instrument that now have two subprocess runs, and
Mads Bertelsen
committed
Merge pull request #57 from PaNOSC-ViNYL/instrument_diagnostics
mads-bertelsen
authored
Version bump to get fixed tests to pypi package.
Mads Bertelsen
committed

Commits on Nov 18, 2022

Update README.md
mads-bertelsen
authored

Commits on Nov 22, 2022

Adding axis1_values and axis2_values to view which plots lines
Mads Bertelsen
committed

Commits on Feb 15, 2023

Commits on Feb 17, 2023

Small fix of component reader when finding vectors
Mads Bertelsen
committed

Commits on Apr 14, 2023

Update syntax for plotting
Peter Willendrup
committed
Update with McStas 3.x relevant syntax
Peter Willendrup
committed
Apply McStas 3.x syntax
Peter Willendrup
committed
Update syntax to get plot outputs
Peter Willendrup
committed
Add Union_init and Union_stop for 3.x support
Peter Willendrup
committed
Updates for Union in McStas 3.x
Peter Willendrup
committed
Update that removes the need to provide a name in often used methods
Mads Bertelsen
committed

Commits on Apr 18, 2023

Addition of ipympl as dependency to fix issues with jupyter notebook widgets not displaying.
Mads Bertelsen
committed
Merge pull request #63 from PaNOSC-ViNYL/implicit_naming
mads-bertelsen
authored
Update of actions to new setup-python version and enabling manual dispatch.
Mads Bertelsen
committed
Update of syntax
Mads Bertelsen
committed
Issue with syntax in github actions.
Mads Bertelsen
committed
Updated duplicate name.
Mads Bertelsen
committed

Commits on Apr 19, 2023

Merge pull request #64 from PaNOSC-ViNYL/actions_update
mads-bertelsen
authored

Commits on Apr 20, 2023

Update of integration tests to support McStas 2 and 3.
Mads Bertelsen
committed
Added openacc and NeXus option to settings, including unit tests.
Mads Bertelsen
committed

Commits on Apr 25, 2023

Added search and dependency keywords.
Mads Bertelsen
committed
Update of documentation and fix of bug in resetting dependency.
Mads Bertelsen
committed
reset notebook.
Mads Bertelsen
committed
Merge pull request #62 from McStasMcXtrace/master
mads-bertelsen
authored
Small changes to readme.
Mads Bertelsen
committed

Commits on Apr 28, 2023

Updating checks of c variable names with regular expressions and
Mads Bertelsen
committed

Commits on May 2, 2023

Updated version of component reader, now handles comments in parameter region.
Mads Bertelsen
committed
Fixed bugs that caused infinite loops.
Mads Bertelsen
committed
Fixed spelling mistake in comment.
Mads Bertelsen
committed
Update version number as behavior changed.
Mads Bertelsen
committed
Merge pull request #69 from PaNOSC-ViNYL/comp_reader_improvements
mads-bertelsen
authored

Commits on Jun 8, 2023

[Apply][Fix] On top of the up-to-date master
g5t
committed

Commits on Jun 9, 2023

[Fix] white space issues for tests
g5t
committed

Commits on Jun 15, 2023

Small bug pointed out by Kristine which prevented diagnostic output
Mads Bertelsen
committed

Commits on Aug 4, 2023

Small updates:
Mads Bertelsen
committed

Commits on Aug 29, 2023

Update that allows reading of nexus files with load functions.
Mads Bertelsen
committed

Commits on Aug 30, 2023

Commits on Dec 1, 2023

Fixed issue with placement of plot in widget on newer ipywidget versions.
Mads Bertelsen
committed
Merge pull request #75 from PaNOSC-ViNYL/new_widget_layout
mads-bertelsen
authored
mcdisplay is now searched for in both exectuable path and package path.
Mads Bertelsen
committed
Tight layout on all figures
Mads Bertelsen
committed
Bump of version.
Mads Bertelsen
committed
Fixed called_with parameters in unittests for plotting.
Mads Bertelsen
committed
Merge pull request #76 from PaNOSC-ViNYL/show_instrument_fix
mads-bertelsen
authored
Hotfix of mcdisplay path issue.
Mads Bertelsen
committed
Hotfix of mcdisplay path issue.
Mads Bertelsen
committed

Commits on Dec 6, 2023

Improved reliability of reading NeXus data.
Mads Bertelsen
committed

Commits on Dec 7, 2023

Merge pull request #77 from PaNOSC-ViNYL/nexus_loading_improvements
mads-bertelsen
authored

Commits on Dec 14, 2023

Mocked datetime to avoid a flaky test when writing instrument code.
Mads Bertelsen
committed

Commits on Feb 10, 2024

Implement simple solution to auto-detect McStas and McXtrace parameters if run from within a related 'environment'
willend
committed

Commits on Feb 14, 2024

Merge pull request #78 from willend/master
mads-bertelsen
authored
Fix of case where MCSTAS was not found in environ.
Mads Bertelsen
committed

Commits on May 15, 2024

Commits on Jul 25, 2024

Further development of instrument_checker and version bump.
mads-bertelsen
committed

Commits on Jul 29, 2024

Updated search statements so McStasScript loads the appropriate folder of components.
mads-bertelsen
committed

Commits on Aug 9, 2024

Commits on Aug 21, 2024

fix bad escape sequence warning in python 3.11
nvaytet
committed

Commits on Sep 11, 2024

Commits on Oct 17, 2024

fixed typos in Union tutorial docs
MilanKlausz
committed

Commits on Oct 18, 2024

fixed typos in Union tutorials
MilanKlausz
committed

Commits on Nov 8, 2024

Commits on Apr 2, 2025

Commits on Aug 12, 2025

Let McStasScript default to use of webgl-classic vis.
willend
committed

Commits on Aug 19, 2025

Commits on Nov 24, 2025

Merge pull request #86 from MilanKlausz/master
mads-bertelsen
authored