Change server update loop from NoWait to Default#36
Open
inert-aesthetic wants to merge 1 commit intoPXshadow:masterfrom
Open
Change server update loop from NoWait to Default#36inert-aesthetic wants to merge 1 commit intoPXshadow:masterfrom
inert-aesthetic wants to merge 1 commit intoPXshadow:masterfrom
Conversation
Change reduces idle CPU usage by a large amount. (100% to 0%)
Contributor
|
One issue is that function main() {
new weblink.Weblink().listen(2000, false);
trace("hello!"); // isn't called with this patch
}Also, because MainLoop/Thread.events are not integrated with the libuv loop, I do not expect any timers will be ran either. |
Owner
Maybe we could build out a system to run the timers using a background thread for the Haxe std. I know for example Heaps.io has to handle the haxe.Timer system as well as openFL instead of the std, where as targets such as JS work out of the box. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change reduces idle CPU usage by a large amount. (100% to 0%)
Needs testing.
I have confirmed only that POST and GET requests with plain text still work.