Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Phosphor-icons import error on pages with SSR #79

Merged
merged 9 commits into from
Mar 29, 2024
Merged

fix: Phosphor-icons import error on pages with SSR #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1a08492
fix: fix phosphor icons SSR issue
Karmotrine Mar 28, 2024
b5faf4a
fix: phosphoricons SSR issue (#2)
Karmotrine Mar 28, 2024
e22cfeb
fix: SSR issue with phosphor icons (#3)
Karmotrine Mar 28, 2024
2cc316d
remove phosphor-icons/react from optimizePackageImports in next.confi…
Karmotrine Mar 28, 2024
6fc5a81
disable all next/dynamic imports
Karmotrine Mar 28, 2024
2e85f97
update to latest version of nextjs
Karmotrine Mar 28, 2024
4aa11ee
add experimental optimizePackageImports back
Karmotrine Mar 28, 2024
e459b79
add phosphor-icons to modularizeImports within next.config.js
Karmotrine Mar 28, 2024
f0a696f
change icon import paths on ui components
Karmotrine Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,31 @@ const withBundleAnalyzer = require("@next/bundle-analyzer")({
/** @type {import('next').NextConfig} */
const nextConfig = {
experimental: {
appDir: false,
optimizePackageImports: ["@phosphor-icons/react"],
},
modularizeImports: {
"@phosphor-icons/react": {
transform: "@phosphor-icons/react/dist/ssr/{{member}}",
},
},
images: {
domains: ["images.unsplash.com", "picsum.photos", process.env.S3_BUCKET],
remotePatterns: [
{
protocol: "https",
hostname: "images.unsplash.com",
port: "",
},
{
protocol: "https",
hostname: "picsum.photos",
port: "",
},
{
protocol: "https",
hostname: process.env.S3_BUCKET,
port: "",
},
],
},
};

Expand Down
Loading