-
Notifications
You must be signed in to change notification settings - Fork 43
fix(linting): fixed linting to handle linting for JAVA and XML files #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update the lint-staged configuration within the Changes
Poem
π Recent review detailsConfiguration used: CodeRabbit UI π Files selected for processing (1)
π§ Files skipped from review as they are similar to previous changes (1)
β° Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
β Files ignored due to path filters (1)
checkstyle.jaris excluded by!**/*.jar
π Files selected for processing (1)
package.json(1 hunks)
β° Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
π Additional comments (1)
package.json (1)
16-18: Verify ESLint patterns for TypeScript/JavaScript and removed file types
The glob"src/**/*.{ts,js}"now only targets.tsand.js. Confirm that dropping.cssand.htmlfrom your ESLint step is intentionalβif you still need to lint those files, youβll want to reintroduce them or wire up stylelint/HTMLLint. Also consider whether you need to include.jsx/.tsx.
checkstyle.jar
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zapper9982 let's not commit binary files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay! @drtechie should i figure out thje checkstyle.xml configuration to have linting implemented then ?
|



π Description
JIRA ID:
Updated the linting to handle .java and .xml files
Checkstyle.jarwhich allows linting for .java filesxmllintfor linting xml filesβ Type of Change
Screenshots
Summary by CodeRabbit