Skip to content

minor changes in the PCA/T-SNE #19

Merged
ypriverol merged 1 commit intomainfrom
dev
Mar 18, 2026
Merged

minor changes in the PCA/T-SNE #19
ypriverol merged 1 commit intomainfrom
dev

Conversation

@ypriverol
Copy link
Contributor

@ypriverol ypriverol commented Mar 18, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fine-tuned annotation positioning in quality control frequency distribution visualizations to enhance readability and visibility of important statistical markers and thresholds
    • Reorganized header element placement and ordering in quality control reports across multiple report types to improve visual hierarchy, layout clarity, and user navigation

@ypriverol ypriverol merged commit f7869fb into main Mar 18, 2026
12 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ed860f93-8a65-4bde-b33a-48a78e049e7a

📥 Commits

Reviewing files that changed from the base of the PR and between a8ae914 and 306af38.

📒 Files selected for processing (2)
  • src/pyprideap/viz/qc/render.py
  • src/pyprideap/viz/qc/report.py

📝 Walkthrough

Walkthrough

The PR adjusts QC visualization layout by repositioning annotations in the Missing Frequency Distribution subplot (moving from left to right alignment) and reordering header elements in QC report rendering (adjusting help-toggle and extra_header placement).

Changes

Cohort / File(s) Summary
QC Visualization Annotations
src/pyprideap/viz/qc/render.py
Adjusted positioning and anchoring of annotations in Missing Frequency Distribution subplot; moved annotation x-position from 0.02 to 0.98 with xanchor changed from "left" to "right", and updated 30% threshold annotation vertical alignment.
QC Report Header Ordering
src/pyprideap/viz/qc/report.py
Reordered header elements in QC report functions; in qc_report, extra_header block now renders after the title and help-toggle button; in qc_report_split, help-toggle renders before toggle_html in Dimensionality Reduction header.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • selvaebi
  • chakrabandla

Poem

🐰 With a hop and a tweak, the layout's refined,
Annotations repositioned, perfectly aligned,
Headers reordered with care and with grace,
Each element finding its proper place!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant