Dev/account multi op #382
Open
Dev/account multi op #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
huerni
commented
Dec 3, 2024
huerni
commented
- block/unblock account 支持批量操作账户
- block/unblock user 支持同一账户下批量操作用户
- 添加、删除账户/用户的partition、qos 支持批量操作
- 查询账户/用户 支持批量操作
- 删除账户/用户 支持批量操作
Open
RileyWen
reviewed
Dec 3, 2024
src/CraneCtld/AccountManager.cpp
Outdated
| std::unordered_map<std::string, Account>* res_account_map) { | ||
| User res_user; | ||
| CraneExpected<void> result{}; | ||
|
|
||
| std::vector<std::string> account_vec = |
There was a problem hiding this comment.
这个在前端分好吧 后端就不要字符串操作了 字符串操作尽量在前端就做好 后端只处理结构化数据
RileyWen
reviewed
Dec 4, 2024
src/CraneCtld/AccountManager.cpp
Outdated
| if (!user.account_to_attrs_map.at(account).allowed_partition_qos_map.contains( | ||
| partition)) | ||
| return std::unexpected(CraneErrCode::ERR_ALLOWED_PARTITION); | ||
| std::vector<std::string> partition_vec = |
src/CraneCtld/AccountManager.cpp
Outdated
| @@ -1826,12 +1965,17 @@ AccountManager::CraneExpected<void> AccountManager::AddUserAllowedPartition_( | |||
|
|
|||
| User res_user(user); | |||
|
|
|||
| std::vector<std::string> partition_vec = | |||
There was a problem hiding this comment.
这个地方在前端split完吧 不然后端这边参数语义太模糊了
There was a problem hiding this comment.
这个是因为value是共用的，延续之前的写法，改成list的话，modify这一块可能都得改成list
There was a problem hiding this comment.
我又看了一下 确实挺多的，还重复split很多，我改成前端split吧，然后看看其他还有什么问题，没问题改完就可以给周老师测试了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.