Feat: Support cgroupv2 #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RileyWen
reviewed
Oct 3, 2024
L-Xiafeng
reviewed
Oct 3, 2024
L-Xiafeng
reviewed
Oct 3, 2024
Nativu5
reviewed
Oct 5, 2024
L-Xiafeng
reviewed
Oct 10, 2024
RileyWen
reviewed
Oct 18, 2024
RileyWen
reviewed
Oct 18, 2024
L-Xiafeng
reviewed
Oct 21, 2024
L-Xiafeng
reviewed
Oct 21, 2024
L-Xiafeng
reviewed
Oct 21, 2024
L-Xiafeng
reviewed
Oct 21, 2024
L-Xiafeng
reviewed
Oct 21, 2024
L-Xiafeng
reviewed
Oct 22, 2024
wtr0504
force-pushed
the
master
branch
2 times, most recently
from
c994e9b to
e5cdfcd
Compare
L-Xiafeng
reviewed
Oct 22, 2024
wtr0504
force-pushed
the
master
branch
2 times, most recently
from
c29ba6e to
4e590d4
Compare
L-Xiafeng
reviewed
Oct 22, 2024
wtr0504
force-pushed
the
master
branch
3 times, most recently
from
5004918 to
f8827fc
Compare
RileyWen
reviewed
Oct 22, 2024
L-Xiafeng
reviewed
Oct 25, 2024
RileyWen
reviewed
Oct 25, 2024
L-Xiafeng
reviewed
Oct 26, 2024
L-Xiafeng
requested changes
Oct 26, 2024
resolve comment resolve commit
…more cgroups load bpf_obj once) reslove comment reslove comment reslove comment fix bug delete BPF_DEBUG compile option resolve comment comment
L-Xiafeng
reviewed
Nov 12, 2024
RileyWen
reviewed
Nov 12, 2024
src/Craned/CgroupManager.cpp
Outdated
| // goto after_migrate; | ||
| // } | ||
| // if ((err = cgroup_get_value_uint64(memory_controller, | ||
| // "memory.move_charge_at_immigrate", |
There was a problem hiding this comment.
memory.move_charge_at_immigrate 这个东西有处理吗
There was a problem hiding this comment.
之前一直是注释的，俊霖之前说删了，看要不要加上
There was a problem hiding this comment.
主要是这个功能 得调研下 我觉得是应该把这个选项开了
wtr0504
force-pushed
the
master
branch
2 times, most recently
from
38a066e to
3c33dff
Compare
L-Xiafeng
reviewed
Nov 13, 2024
L-Xiafeng
previously approved these changes
Nov 13, 2024
RileyWen
previously approved these changes
Nov 13, 2024
L-Xiafeng
reviewed
Nov 13, 2024
RileyWen
approved these changes
Nov 13, 2024
Nativu5
approved these changes
Nov 13, 2024
huerni
pushed a commit
that referenced
this pull request
Jan 7, 2025
* 完成CgroupV2除devices的支持 * 完成对CgroupV2的支持（devices除外） * fix bug * check name * recover config.yaml * get master config.yaml * fix undefined func * solve comments * complete devices support in cgroupV2 by using bpf complete devices support in cgroupV2 by using bpf complete devices support in cgroupV2 by using bpf * rm cmake order * fix bug in bpf dev_map * resolve comment and test multitask resolve comment * refactor Cgroup and reslove comment reslove comment reslove comment reslove comment reslove commit reslove comment reslove comment reslove comment reslove comment reslove comment modify bpf cmake * check and set compile for project * reslove comment of checking compiler version and handling device run_time error in V2 format * resolve comment and modify device access logic on V1 and V2 resolve comment resolve commit * check name * add dynamic load log level in bpf.o,modify bpf_obj load logic(one or more cgroups load bpf_obj once) reslove comment reslove comment reslove comment fix bug delete BPF_DEBUG compile option resolve comment comment * comment * resolve comment * 完成CgroupV2除devices的支持 * 完成对CgroupV2的支持（devices除外） * fix bug * recover config.yaml * get master config.yaml * fix undefined func * solve comments * complete devices support in cgroupV2 by using bpf complete devices support in cgroupV2 by using bpf complete devices support in cgroupV2 by using bpf * rm cmake order * fix bug in bpf dev_map * resolve comment and test multitask resolve comment * refactor Cgroup and reslove comment reslove comment reslove comment reslove comment reslove commit reslove comment reslove comment reslove comment reslove comment reslove comment modify bpf cmake * check and set compile for project * reslove comment of checking compiler version and handling device run_time error in V2 format * resolve comment and modify device access logic on V1 and V2 resolve comment resolve commit * check name * add dynamic load log level in bpf.o,modify bpf_obj load logic(one or more cgroups load bpf_obj once) reslove comment reslove comment reslove comment fix bug delete BPF_DEBUG compile option resolve comment comment * comment * resolve comment * add v2 option CRANE_ENABLE_CGROUP_V2 and communicate with CRANE_USE_SYSTEM_LIBCGROUP * comment commit comment comment * rm pkg check libcgroup * comment * comment * add memory.move_charge_at_immigrate todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加对cgroupV2的支持，device已实现