Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto aux update check #94

Merged
merged 10 commits into from
Mar 4, 2024
Merged

Auto aux update check #94

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
984694e
Trigger Build
shahronak47 Feb 1, 2024
4f00dc7
include additional condition
shahronak47 Feb 1, 2024
6b81989
add read_signature_file function
shahronak47 Feb 9, 2024
239c633
update data reading signature files
shahronak47 Feb 9, 2024
e3820e2
change args
shahronak47 Feb 9, 2024
2e60341
change time
shahronak47 Feb 9, 2024
00c39d1
add new var to track file change
shahronak47 Feb 9, 2024
6e6785b
complete condition
shahronak47 Feb 9, 2024
f2297e3
fix formating a little
randrescastaneda Feb 15, 2024
caa1309
Merge pull request #96 from PIP-Technical-Team/auto-aux-update-review
shahronak47 Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 31 additions & 24 deletions R/auto_aux_update.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,31 +99,38 @@ auto_aux_update <- function(measure = NULL,
suppressMessages()
}
}

# Write the latest auxiliary file and corresponding hash to csv
# Always save at the end.
# sha - hash object of current csv file in Data/git_metadata.csv
# content - base64 of changed data
out <- gh::gh("GET /repos/{owner}/{repo}/contents/{file_path}",
owner = "PIP-Technical-Team",
repo = "pipaux",
file_path = "Data/git_metadata.csv",
.params = list(ref = "metadata"))

res <- gh::gh("PUT /repos/{owner}/{repo}/contents/{path}",
owner = "PIP-Technical-Team",
repo = "pipaux",
path = "Data/git_metadata.csv",
.params = list(branch = "metadata",
message = "updating csv file",
sha = out$sha, # why does the sha remain the same?
content = convert_df_to_base64(all_data)
),
.token = Sys.getenv("GITHUB_PAT")
)

cli::cli_h2("File updated status.")
out <- aux_file_last_updated(maindir, names(dependencies), branch)
if(length(aux_fns) > 0) {
# Check if the file has updated, only then update the metadata file
# If the files that we wanted to updated were updated today only then write the file
temp_dat <- out |>
dplyr::filter(filename %in% paste0(aux_fns, ".qs")) |>
dplyr::filter(as.Date(time_last_update) == Sys.Date())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't Think this will work well, especially since it is possible to update the same file several times a day

if(nrow(temp_dat) > 0) {
# Write the latest auxiliary file and corresponding hash to csv
# Always save at the end.
# sha - hash object of current csv file in Data/git_metadata.csv
# content - base64 of changed data
out <- gh::gh("GET /repos/{owner}/{repo}/contents/{file_path}",
owner = "PIP-Technical-Team",
repo = "pipaux",
file_path = "Data/git_metadata.csv",
.params = list(ref = "metadata"))

res <- gh::gh("PUT /repos/{owner}/{repo}/contents/{path}",
owner = "PIP-Technical-Team",
repo = "pipaux",
path = "Data/git_metadata.csv",
.params = list(branch = "metadata",
message = "updating csv file",
sha = out$sha, # why does the sha remain the same?
content = convert_df_to_base64(all_data)
),
.token = Sys.getenv("GITHUB_PAT")
)
}
}
cli::cli_h2("File updated status.")
knitr::kable(out)
}

Expand Down