Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing prefixes and short vignette on release branches #108

Merged
merged 22 commits into from
Jan 22, 2025

Conversation

RossanaTat
Copy link

No description provided.

R/utils.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
Copy link
Member

@randrescastaneda randrescastaneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RossanaTat,
Thanks. Please make sure that this RR does not have any conflict with Tefera's changes. Thank you so much.

@RossanaTat
Copy link
Author

RossanaTat commented Jan 15, 2025 via email

@RossanaTat
Copy link
Author

RossanaTat commented Jan 15, 2025 via email

@RossanaTat RossanaTat changed the title Changing prefixes, adding a general function and short vignette on release branches Changing prefixes and short vignette on release branches Jan 16, 2025
@RossanaTat
Copy link
Author

RossanaTat commented Jan 16, 2025

Hi @randrescastaneda, I believe this PR is ready for merging. I removed the general function, so that this PR is only about prefixes and vignette on release branches. I will work on a different branch to develop the general aux function and dependency workflow. Thank you!

Copy link
Member

@randrescastaneda randrescastaneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, just make the change that we discussed. Thanks.

@RossanaTat
Copy link
Author

all good, just make the change that we discussed. Thanks.

Hi @randrescastaneda, thank you, I have reorganized all functions across files and pushed.

@randrescastaneda randrescastaneda merged commit 8acf2a9 into DEV_v2 Jan 22, 2025
@randrescastaneda randrescastaneda deleted the Rossana_DEV branch January 22, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants