-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing prefixes and short vignette on release branches #108
Conversation
Merged DEV_v2_tefera_testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RossanaTat,
Thanks. Please make sure that this RR does not have any conflict with Tefera's changes. Thank you so much.
[like] ROSSANA TATULLI reacted to your message:
…________________________________
From: R.Andrés Castañeda ***@***.***>
Sent: Tuesday, January 14, 2025 11:41:22 PM
To: PIP-Technical-Team/pipaux ***@***.***>
Cc: ROSSANA TATULLI ***@***.***>; Mention ***@***.***>
Subject: Re: [PIP-Technical-Team/pipaux] Changing prefixes, adding a general function and short vignette on release branches (PR #108)
@randrescastaneda requested changes on this pull request.
Hi @RossanaTat<https://github.com/RossanaTat>,
Thanks. Please make sure that this RR does not have any conflict with Tefera's changes. Thank you so much.
—
Reply to this email directly, view it on GitHub<#108 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BD5CFDLJGCK3P67VDUDIL2L2KWOCFAVCNFSM6AAAAABUDOJZO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJRGI2TKMRUHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
[like] ROSSANA TATULLI reacted to your message:
________________________________
From: R.Andrés Castañeda ***@***.***>
Sent: Tuesday, January 14, 2025 11:38:20 PM
To: PIP-Technical-Team/pipaux ***@***.***>
Cc: ROSSANA TATULLI ***@***.***>; Mention ***@***.***>
Subject: Re: [PIP-Technical-Team/pipaux] Changing prefixes, adding a general function and short vignette on release branches (PR #108)
@randrescastaneda commented on this pull request.
________________________________
In R/utils.R<#108 (comment)>:
\ No newline at end of file
+}
+
+#' Call auxiliary function for a specified measure
+#'
+#' @param measure character: Name of the auxiliary data measure (e.g., "ppp")
+#' @param package_name character: Name of the package containing the auxiliary function (default is "pipaux")
+#' @param ... additional arguments to pass to the auxiliary function
+#'
+#' @return The result of the auxiliary function call.
+call_aux_function <- function(measure,
Hi @RossanaTat<https://github.com/RossanaTat>,
Thank you so much.let's talk about it tomorrow morning.Best.
—
Reply to this email directly, view it on GitHub<#108 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BD5CFDNFCLZI32WVHGU5JX32KWNWZAVCNFSM6AAAAABUDOJZO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJRGI2TENJQGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @randrescastaneda, I believe this PR is ready for merging. I removed the general function, so that this PR is only about prefixes and vignette on release branches. I will work on a different branch to develop the general |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, just make the change that we discussed. Thanks.
Hi @randrescastaneda, thank you, I have reorganized all functions across files and pushed. |
No description provided.